Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly round to min tick size for multiple hops #9

Closed
gorgos opened this issue Aug 8, 2023 · 0 comments · Fixed by #11
Closed

Properly round to min tick size for multiple hops #9

gorgos opened this issue Aug 8, 2023 · 0 comments · Fixed by #11
Labels
bug Something isn't working

Comments

@gorgos
Copy link
Member

gorgos commented Aug 8, 2023

We forgot to round down to min tick size in intermediate steps.

Quick fix would just be adding the rounding, but we shouldn't rush this, because maybe we also have to apply this rounding for the SwapExact case? And we should add proper testing for this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@gorgos