New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add reverse quantity estimation query and event #6

Merged

gorgos merged 46 commits into master from f/reverse-estimate-and-swap-event

Jul 6, 2023

Member

gorgos commented Jun 27, 2023

No description provided.


          feat: add reverse quantity estimation query

bb7e0b8

gorgos requested a review from Tofel

June 27, 2023 18:48

gorgos temporarily deployed to github-pages

June 27, 2023 18:48

— with

GitHub Actions Inactive


          chore: add swap event

43e3f96

gorgos force-pushed the f/reverse-estimate-and-swap-event branch from fab4b83 to 43e3f96 Compare

June 27, 2023 18:49

gorgos temporarily deployed to github-pages

June 27, 2023 18:49

— with

GitHub Actions Inactive

arcayne reviewed

View reviewed changes

contracts/swap/Cargo.toml Outdated Show resolved Hide resolved

arcayne reviewed

View reviewed changes

contracts/swap/src/swap.rs Show resolved Hide resolved


          chore: rename swap contract package

0a436a7

gorgos had a problem deploying to github-pages

June 28, 2023 05:41

— with

GitHub Actions Failure

vinhphuctadang reviewed

View reviewed changes

contracts/swap/src/swap.rs Outdated Show resolved Hide resolved


          chore: remove contract type and version from swap event

fc679d7

* not needed

gorgos had a problem deploying to github-pages

June 28, 2023 05:47

— with

GitHub Actions Failure

vinhphuctadang previously approved these changes

View reviewed changes

Tofel reviewed

View reviewed changes

contracts/swap/src/queries.rs Outdated Show resolved Hide resolved

Tofel reviewed

View reviewed changes

contracts/swap/src/queries.rs Show resolved Hide resolved

Tofel reviewed

View reviewed changes

contracts/swap/src/queries.rs Outdated Show resolved Hide resolved

Tofel reviewed

View reviewed changes

contracts/swap/src/queries.rs Show resolved Hide resolved

Tofel reviewed

View reviewed changes

contracts/swap/src/queries.rs Outdated Show resolved Hide resolved

Tofel reviewed

View reviewed changes

contracts/swap/src/queries.rs Show resolved Hide resolved

Tofel reviewed

View reviewed changes

contracts/swap/src/swap.rs

+                  // need to remove protobuf scale factor to get real values
+                  let average_price = FPDecimal::from_str(&trade_data.price)? / dec_scale_factor;
+                  let quantity = FPDecimal::from_str(&trade_data.quantity)? / dec_scale_factor;

Contributor

Tofel Jun 28, 2023

maybe we could use proto_to_dec function?

Member Author

gorgos Jun 29, 2023

damn its not yet in cw-injective though

gorgos added 2 commits

June 28, 2023 13:30


          fix: change helix to injective

c963c95


          feat: add exact output swap function

c80f0e1

Tofel reviewed

View reviewed changes

contracts/swap/src/swap.rs Show resolved Hide resolved

Tofel reviewed

View reviewed changes

contracts/swap/src/testing/swap_tests.rs Outdated Show resolved Hide resolved

Contributor

Tofel commented Jun 28, 2023

what I'm missing here the most, @gorgos are tests for source part. Where are they? 🤔


          fix: round up to market quantity tick size

5860a98

gorgos dismissed vinhphuctadang’s stale review via

5860a98

June 28, 2023 11:39

gorgos temporarily deployed to github-pages

June 28, 2023 11:39

— with

GitHub Actions Inactive


          chore: fix fee handling + query test

a4ea451

gorgos had a problem deploying to github-pages

July 4, 2023 08:42

— with

GitHub Actions Failure

Tofel added 3 commits

July 5, 2023 13:23


          chore: added tests for exact swap quantity

9ce2e83


          chore: more exact tests

c8c88d7


          chore: small refactorings of tests

171de8c

Tofel had a problem deploying to github-pages

July 5, 2023 13:21

— with

GitHub Actions Failure


          chore: last formatting touches

e00838d

Tofel had a problem deploying to github-pages

July 5, 2023 13:25

— with

GitHub Actions Failure


          chore: make last tests pass

d73162b

Tofel had a problem deploying to github-pages

July 5, 2023 15:05

— with

GitHub Actions Failure


          chore: bump rustc version used in GHA

2c89822

Tofel had a problem deploying to github-pages

July 5, 2023 15:08

— with

GitHub Actions Failure


          chore: cargo fmt

e7daf0f

Tofel had a problem deploying to github-pages

July 5, 2023 15:10

— with

GitHub Actions Failure


          chore: fix lints

03351b6

Tofel had a problem deploying to github-pages

July 5, 2023 15:23

— with

GitHub Actions Failure


          chore: fix rustc version

d6760b4

Tofel had a problem deploying to github-pages

July 5, 2023 15:29

— with

GitHub Actions Failure


          chore: update Injective dependencies to latest versions to try to sol…

fc0f485

…ve dependency mismatch issue

Tofel had a problem deploying to github-pages

July 6, 2023 08:26

— with

GitHub Actions Failure


          chore: fix compilation errors

e0cd9c9

Tofel temporarily deployed to github-pages

July 6, 2023 09:36

— with

GitHub Actions Inactive


          chore: lints

ffcd42f

Tofel temporarily deployed to github-pages

July 6, 2023 09:41

— with

GitHub Actions Inactive


          chore: run lints with specified toolchain

Tofel temporarily deployed to github-pages

July 6, 2023 10:13

— with

GitHub Actions Inactive

gorgos commented

View reviewed changes

Member Author

gorgos left a comment

LGTM

gorgos merged commit c67f2a4 into master

gorgos deleted the f/reverse-estimate-and-swap-event branch

August 18, 2023 10:56

This was referenced Mar 22, 2024

demo of ai audit #17

Closed

ai audit demo yubrew/swap-contract#2

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet