Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create transitioning-contractor-code-to-innersource-model #377

Merged
merged 28 commits into from
Oct 10, 2022
Merged

Create transitioning-contractor-code-to-innersource-model #377

merged 28 commits into from
Oct 10, 2022

Conversation

claredillon
Copy link
Member

Added new pattern as discussed in #375

@claredillon claredillon changed the title Create transitioning-contractor-code-to-InnerSource-model Create transitioning-contractor-code-to-innersource-model Dec 18, 2021
@claredillon claredillon marked this pull request as draft December 18, 2021 07:24
@claredillon
Copy link
Member Author

@zkoppert - can you take a look at this please and see if you would add any details. It would be great if we could add some explicit steps to transition if we can...

@spier
Copy link
Member

spier commented Dec 18, 2021

Nice job @claredillon! I added the .md extension to the file.

This also results in our markdown syntax linter to check this file, which is why you should have received some email notifications with syntax warnings. I tried to fix some of them but not sure if I found all.

zkoppert
zkoppert approved these changes Dec 20, 2021
View reviewed changes
Copy link
Member

@zkoppert zkoppert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for writing this up Clare!!

patterns/1-initial/transitioning-contractor-code-to-innersource-model.md Outdated Show resolved Hide resolved
patterns/1-initial/transitioning-contractor-code-to-innersource-model.md Outdated Show resolved Hide resolved
patterns/1-initial/transitioning-contractor-code-to-innersource-model.md Outdated Show resolved Hide resolved
patterns/1-initial/transitioning-contractor-code-to-innersource-model.md Outdated Show resolved Hide resolved
patterns/1-initial/transitioning-contractor-code-to-innersource-model.md Outdated Show resolved Hide resolved
spier and others added 2 commits December 20, 2021 08:23
spier
spier requested changes Jan 7, 2022
View reviewed changes
Copy link
Member

@spier spier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@claredillon great start. 🚀

I worked in some of Zack's feedback and added further comments of my own.

It would be great to get this pattern merged as Initial in the short term, to gather further feedback from the Community before publishing it in our book.

Btw does anything speak against turning this PR from "Draft" into "Ready for review"?

patterns/1-initial/transitioning-contractor-code-to-innersource-model.md Show resolved Hide resolved
patterns/1-initial/transitioning-contractor-code-to-innersource-model.md Outdated Show resolved Hide resolved
patterns/1-initial/transitioning-contractor-code-to-innersource-model.md Outdated Show resolved Hide resolved
patterns/1-initial/transitioning-contractor-code-to-innersource-model.md Outdated Show resolved Hide resolved
patterns/1-initial/transitioning-contractor-code-to-innersource-model.md Outdated Show resolved Hide resolved
patterns/1-initial/transitioning-contractor-code-to-innersource-model.md Outdated Show resolved Hide resolved
patterns/1-initial/transitioning-contractor-code-to-innersource-model.md Outdated Show resolved Hide resolved
patterns/1-initial/transitioning-contractor-code-to-innersource-model.md Outdated Show resolved Hide resolved
patterns/1-initial/transitioning-contractor-code-to-innersource-model.md Outdated Show resolved Hide resolved
patterns/1-initial/transitioning-contractor-code-to-innersource-model.md Outdated Show resolved Hide resolved
@spier spier mentioned this pull request Jan 8, 2022
Draft
@zkoppert
Copy link
Member

@claredillon It looks like some of @spier's comments are directed towards your part of the content. Just dropping your name here as a reminder to address those comments.

@spier spier added 1-initial Donuts, Early pattern ideas, ... (Please see our contribution handbook for details) 📖 Type - Content Work Working on contents is the main focus of this issue / PR labels Jan 24, 2022
@spier
Copy link
Member

spier commented Apr 2, 2022

@claredillon how shall we proceed on this PR?

claredillon and others added 5 commits October 10, 2022 10:11
claredillon
claredillon commented Oct 10, 2022
View reviewed changes
Copy link
Member Author

@claredillon claredillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're good to go now @spier ??

@spier spier marked this pull request as ready for review October 10, 2022 09:51
@spier spier requested a review from robtuley as a code owner October 10, 2022 09:51
spier
spier approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@spier spier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed the remaining points with @claredillon, and we fixed all open comment threads.
Will merge this shortly.

@spier spier merged commit a410adc into InnerSourceCommons:main Oct 10, 2022
@chamindra chamindra mentioned this pull request Nov 15, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkoppert zkoppert zkoppert approved these changes

@spier spier spier approved these changes

@cewilliams cewilliams Awaiting requested review from cewilliams cewilliams is a code owner

@lenucksi lenucksi Awaiting requested review from lenucksi lenucksi is a code owner

@NewMexicoKid NewMexicoKid Awaiting requested review from NewMexicoKid NewMexicoKid is a code owner

@robtuley robtuley Awaiting requested review from robtuley robtuley is a code owner

Assignees
No one assigned
Labels
1-initial Donuts, Early pattern ideas, ... (Please see our contribution handbook for details) 📖 Type - Content Work Working on contents is the main focus of this issue / PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@claredillon @spier @zkoppert