-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Release Process pattern to L2 (Structured) #524
Move Release Process pattern to L2 (Structured) #524
Conversation
Btw the two failing checks "Generate Mindmap" and "Link Check PR" are ok. The link |
I can look at this either this evening or tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, the pattern deserves structured status as it has come together really nicely. Looking back at #491 it covers all those areas.
Last step before merge -- @dgrizzanti any thoughts on title before it gets harder to change it?
Bit long perhaps? Is "Published Artifacts" unnecessary in the title -- i.e. it is part of the release process? Could switch to "Standard Release Process"? |
@robtuley shortening the title sounds good to me. I'll update that. The file name is already the shortened form so that helps 🙂 |
@robtuley should be all set to merge with the updated title! |
I am changing the points in the associated issue #491 to a checklist, so that we can easier "check the list" lol :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for these improvements @dgrizzanti!
The key thing that I would recommend to update before publishing is the Context section, possibly Forces as well.
The Context section doesn't contain the type of content that the pattern template asks for, yet. The two sections Context and Forces are often the hardest to write for new pattern authors, so I would be more than happy to help you to improve this section.
I am a bit short on time right now but I can try to provide an example of an improved Context section some time this weekend.
Co-authored-by: Sebastian Spier <[email protected]>
Also added Standard Base Documentation to this new problem category
Plus a few grammar clean ups
@spier wanted to ping you to see if you had time to review this. Thanks! |
@spier poking on this to see if you had some time to take a look. Thanks! |
Hi @dgrizzanti. Just wanted to let you know that I did not forget about this thread, even though it may seem that way :) I have started a review but it is not quite finished yet. Stay tuned for more, as they say ;) |
Hi @dgrizzanti. You have amazing stamina to still keep working on this, even though feedback has been so slow. Really sorry about this, this is not the experience that we want for our contributors! I promise that I will make my best effort to finish my review this week and send along any remaining questions/ideas that I might have. Thanks again for your work on this! Have a great day. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dgrizzanti thanks for discussing this pattern further.
I had some time right now to put more thoughts in writing. Figured it is better to do a quick version of this that we can talk about, to move this PR forward.
Looking forward to your feedback.
FYI I merged main into this branch, to make sure that our spell checker runs correctly over this new pattern. Spelling looks all good :) |
Co-authored-by: Sebastian Spier <[email protected]>
Co-authored-by: Sebastian Spier <[email protected]>
Co-authored-by: Sebastian Spier <[email protected]>
Co-authored-by: Sebastian Spier <[email protected]>
@spier think I addressed all the new comments and cleaned up a few other small things. Take a look when you get a chance and let me know what you think! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for incorporating the feedback.
This looks great now. Let's push it out into the wild, where it can mature further through the contribution of others, shall we? :)
@dgrizzanti this pattern is now out in the wild and published in our book: Thank you so much for sticking with it and for sharing the concept with the rest of the InnerSource community. Hopefully other people will pick up on this pattern and use it, as well as contribute their own experiences to the pattern. As already mentioned, you can expect to be mentioned as the pattern author on our social channels in the coming weeks, and most likely in the September newsletter of the InnerSource Commons as well. |
Note to self (mostly): i.e. we now got the latest mindmap in our book, which includes the Standard Release Process pattern |
Move Release Process to structured by doing various changes: * Update title * Update problem category (in the mindmap). Also added Standard Base Documentation to this new problem category. * Updates to Context and Force. Plus a few grammar clean ups * Update Patlet * Restructure Problem and Context
Closes #491
@spier let me know what you think about the changes I've made to move this to "Structured". Made a few tweaks. Thanks!