Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating Japanese🇯🇵 / Chinese🇨🇳 page to the latest #548

Merged
merged 11 commits into from
Aug 22, 2023
Merged

Updating Japanese🇯🇵 / Chinese🇨🇳 page to the latest #548

merged 11 commits into from
Aug 22, 2023

Conversation

yuhattor
Copy link
Member

@yuhattor yuhattor commented Jun 18, 2023 •
edited
Loading

Still work in progress

Tasks 🇯🇵

  • (patterns/2-structured/innersource-portal.md)
  • (patterns/2-structured/maturity-model.md)
  • (patterns/2-structured/contracted-contributor.md)
  • (patterns/2-structured/document-your-guiding-principles.md)
  • (patterns/2-structured/crossteam-project-valuation.md)
  • (patterns/2-structured/30-day-warranty.md)
  • (patterns/2-structured/common-requirements.md)
  • (patterns/2-structured/dedicated-community-leader.md)
  • (patterns/2-structured/start-as-experiment.md)
  • (patterns/2-structured/innersource-license.md)
  • (patterns/2-structured/transparent-cross-team-decision-making-using-rfcs.md)
  • (patterns/2-structured/repository-activity-score.md)
  • (patterns/2-structured/trusted-committer.md)
  • (patterns/2-structured/service-vs-library.md)
  • (patterns/2-structured/core-team.md)
  • (patterns/2-structured/praise-participants.md)
  • (patterns/2-structured/review-committee.md)

Tasks 🇨🇳

  • (patterns/2-structured/innersource-portal.md)
  • (patterns/2-structured/maturity-model.md)
  • (patterns/2-structured/contracted-contributor.md)
  • (patterns/2-structured/document-your-guiding-principles.md)
  • (patterns/2-structured/crossteam-project-valuation.md)
  • (patterns/2-structured/30-day-warranty.md)
  • (patterns/2-structured/common-requirements.md)
  • (patterns/2-structured/dedicated-community-leader.md)
  • (patterns/2-structured/start-as-experiment.md)
  • (patterns/2-structured/innersource-license.md)
  • (patterns/2-structured/transparent-cross-team-decision-making-using-rfcs.md)
  • (patterns/2-structured/repository-activity-score.md)
  • (patterns/2-structured/trusted-committer.md)
  • (patterns/2-structured/service-vs-library.md)
  • (patterns/2-structured/core-team.md)
  • (patterns/2-structured/praise-participants.md)
  • (patterns/2-structured/review-committee.md)

@yuhattor yuhattor linked an issue Jun 18, 2023 that may be closed by this pull request
🇯🇵 Japanese: Content Consistency Issue #546
Closed
@yuhattor yuhattor linked an issue Jun 18, 2023 that may be closed by this pull request
🇨🇳 Chinese: Content Consistency Issue #547
Closed
This was referenced Jun 18, 2023
Closed
Closed
@yuhattor yuhattor changed the title [WIP] Updating Japanese page to the latest [WIP] Updating Japanese🇯🇵 / Chinese🇨🇳 page to the latest Jun 18, 2023
@yuhattor yuhattor changed the title [WIP] Updating Japanese🇯🇵 / Chinese🇨🇳 page to the latest Updating Japanese🇯🇵 / Chinese🇨🇳 page to the latest Jun 18, 2023
@yuhattor yuhattor requested a review from spier June 18, 2023 13:39
@yuhattor
Copy link
Member Author

yuhattor commented Jun 18, 2023 •
edited
Loading

@spier
I have completed the update on the PR here. Could you check it out?
There are no essential changes. Just the update date and time have been changed.

@yuhattor yuhattor added the i18n label Jun 18, 2023
@spier spier added the Type - Translation Translating patterns into other languages label Jun 19, 2023
@yuhattor yuhattor removed the i18n label Jun 19, 2023
spier
spier approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@spier spier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Feel free to merge.

We can deploy these changes to gitbook at a later point, as there are no essential content changes.

Just one question, what do these mean?

2023-06-18 - 最終更新

and

2023-06-18 最后更新日期

Also I didn't know that you speak Chinese as well? :)

@spier
Copy link
Member

spier commented Jul 1, 2023

@yuhattor please see last comment above.

I assume that this PR also fixes the new issues that were opened? #553 and #554?

@yuhattor
Copy link
Member Author

yuhattor commented Jul 3, 2023

Thank you. This is "last updated date" in Japanese and Chinese. I can't speak Chinese but my wife can 🇨🇳

The program uses the diff command to inform you of differences if the language file is older than the last modification date of the original English file.

On the other hand, some small changes do not require translation. For instance, the word "Acknowledgement" and "Acknowledgements" do not differ in translation words in Japanese. This is because Japanese does not have an English-like plural form. But if you do not update the page, the script will forever point out that there is a difference between "Acknowledgement" and "Acknowledgements".

For this reason, I update the file with the date and time of the last update. The other reason is that it is simply better to know when the page was last updated 👍

@yuhattor
Copy link
Member Author

yuhattor commented Jul 3, 2023

For the below, let me check later!

I assume that this PR also fixes the new issues that were opened? #553 and #554?

@spier
Copy link
Member

spier commented Jul 3, 2023

Thank you. This is "last updated date" in Japanese and Chinese. I can't speak Chinese but my wife can 🇨🇳

The program uses the diff command to inform you of differences if the language file is older than the last modification date of the original English file.

On the other hand, some small changes do not require translation. For instance, the word "Acknowledgement" and "Acknowledgements" do not differ in translation words in Japanese. This is because Japanese does not have an English-like plural form. But if you do not update the page, the script will forever point out that there is a difference between "Acknowledgement" and "Acknowledgements".

For this reason, I update the file with the date and time of the last update. The other reason is that it is simply better to know when the page was last updated 👍

Thank you for these explanations @yuhattor. Especially great that you have an amazing co-translator so close by :)

Shall I already go ahead and merge this PR then, so that no further translation issues are automatically opened?

@spier
Copy link
Member

spier commented Aug 22, 2023

Hi @yuhattor. Shall I already go ahead and merge this PR, so that no further translation issues are automatically opened?

@yuhattor
Copy link
Member Author

Yes, please!

@yuhattor
Copy link
Member Author

I think, there's no further big transition issues now.

@spier spier merged commit 36e2ca8 into main Aug 22, 2023
@spier spier deleted the updating-japanese-page branch August 22, 2023 08:37
@spier
Copy link
Member

spier commented Aug 22, 2023

Awesome, thank you so much @yuhattor. This is now merged.

@yuhattor
Copy link
Member Author

Thank you!

@spier spier mentioned this pull request Aug 29, 2023
Open
rmarting pushed a commit to rmarting/InnerSourcePatterns that referenced this pull request Feb 29, 2024
@yuhattor @rmarting
Updating Japanese🇯🇵 / Chinese🇨🇳 page to the latest (InnerSourceCommon…
478a225 
…s#548)

* Updated Japanese translation - innersource-portal.md
* Updated Japanese translation - maturity-model.md
* Checked Japanese translation - contracted-contributor.md
* Update translation history
* Checked Japanese translation - document-your-guiding-principles.md
* Japanese translation - Checked files that do not need to be updated and update the update date
* Check the i18n 🇨🇳 consistency
* Remove individual names from consistency check-only update information
* Inserted new-line to pass the lint checker
* Update the updated date
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spier spier spier approved these changes

Assignees
No one assigned
Labels
Type - Translation Translating patterns into other languages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🇨🇳 Chinese: Content Consistency Issue 🇯🇵 Japanese: Content Consistency Issue
2 participants
@yuhattor @spier