Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing link fragments in translations #590

Merged
merged 10 commits into from
Sep 12, 2023
Merged

Conversation

spier
Copy link
Member

@spier spier commented Sep 12, 2023

Markdownlint reported some issue.
Not sure why now and not earlier. i.e. not sure what changed :)

Trying to fix these.

@spier spier changed the title Fixing links in pt-br book introduction Fixing link fragments in translations Sep 12, 2023
@spier spier added the (Self-) Hosting Everything around artifact rendering and presentation. label Sep 12, 2023
@spier spier merged commit c6e300f into main Sep 12, 2023
9 checks passed
@spier spier deleted the fixing-MD051-link-fragments branch September 12, 2023 22:54
@spier
Copy link
Member Author

spier commented Sep 12, 2023

I clicked through the respective links in all translations (ja, zh, pt-br) and the link fragments are working now.
Also markdown lint check is green again. So all good, for now.

Still no clue why this issue was reported by markdownlint now, and not earlier.

@spier
Copy link
Member Author

spier commented Sep 13, 2023

Likely we saw these issues due to one of these:
DavidAnson/markdownlint#954
DavidAnson/markdownlint#955

I cannot tell what changes markdownlint made exactly. It may have happened in these commits:
DavidAnson/markdownlint@1ddee6b
DavidAnson/markdownlint@ba260b9

rmarting pushed a commit to rmarting/InnerSourcePatterns that referenced this pull request Feb 29, 2024
Fixing issues with link fragments (MD051) in all translations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(Self-) Hosting Everything around artifact rendering and presentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant