Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create pattern-metrics.yaml #593

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Create pattern-metrics.yaml #593

merged 2 commits into from
Oct 10, 2023

Conversation

zkoppert
Copy link
Member

@zkoppert zkoppert commented Oct 9, 2023

Getting started measuring pattern metrics. Related to #565.

This pull request implements

  • Time to first response metrics for new issues (excluding codeowners created) recurring every month
  • Time to first response metrics for new pull requests (excluding codeowners created) recurring every month

cc/ @spier

Getting started measuring pattern metrics. Related to #565. 

This pull request implements
- Time to first response metrics for new issues (excluding codeowners created) recurring every month
- Time to first response metrics for new pull requests (excluding codeowners created) recurring every month
@zkoppert
Copy link
Member Author

zkoppert commented Oct 9, 2023

I did some local testing of the parts and pieces in these workflows and it does seem to work. Next I'll work on getting metrics on,

  • number of new Structured patterns
  • number of new Initial patterns
  • number of new Known Instances for an existing pattern

@zkoppert
Copy link
Member Author

zkoppert commented Oct 9, 2023

@spier Any idea what happened on the failing GitBook Generation? Maybe a permissions issue?

@spier
Copy link
Member

spier commented Oct 9, 2023

@zkoppert the issue is likely still related to issue #581.
For the time being we can just ignore those failing Gitbook generations.

@spier
Copy link
Member

spier commented Oct 9, 2023

@zkoppert thank you for this PR!

I was going through your code, trying to understand how it works, and what it does.

Where I got stuck was that I don't see the issue_metrics.md file mentioned in the GHA in this PR.
Is it missing? Or does it get created by something else that I don't see here?

Thanks again for helping us collect helpful metrics about the way that contributions work on this repo.

@spier
Copy link
Member

spier commented Oct 9, 2023

Ah, I think I see it now in the docs:
https://github.com/marketplace/actions/issue-metrics

The github/issue-metrics@v2 step is creating the issue_metrics.md file, right?

@zkoppert
Copy link
Member Author

zkoppert commented Oct 9, 2023

Ah, I think I see it now in the docs: https://github.com/marketplace/actions/issue-metrics

The github/issue-metrics@v2 step is creating the issue_metrics.md file, right?

Yup, that is exactly it. The issue_metrics.md file gets created by the github/issue-metrics action.

@spier spier added the ⚙️ Type - Meta Improving how we collaborate in this repo is the main focus of this issue / PR label Oct 10, 2023
@spier
Copy link
Member

spier commented Oct 10, 2023

@zkoppert if you like, you can pull from main again. I made the CODEOWNERS file a bit simpler, so you will have less clutter in there when extracting the info from there via your script.

Copy link
Member

@spier spier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I understand the GHA creates one issue for each "report type".

e.g.

  • issue (1) "Monthly New Issues Data 2023-10-01..2023-10-31"
  • issue (2) "Monthly New Pull Request Data 2023-10-01..2023-10-31"

I left some other comments inline, mostly to understand better how this works.

I am happy to merge this, so that we can try it out.

Would we run in once manually, so that the first reports are generated immediately?

.github/workflows/pattern-metrics.yaml Show resolved Hide resolved
.github/workflows/pattern-metrics.yaml Show resolved Hide resolved
.github/workflows/pattern-metrics.yaml Show resolved Hide resolved
Co-authored-by: Sebastian Spier <[email protected]>
@spier
Copy link
Member

spier commented Oct 10, 2023

@zkoppert should I go ahead and merge + run this GHA already as a first test "in Production"? :)

@zkoppert
Copy link
Member Author

@spier yes, that sounds good!

@spier spier merged commit a9fa85d into InnerSourceCommons:main Oct 10, 2023
2 of 6 checks passed
rmarting pushed a commit to rmarting/InnerSourcePatterns that referenced this pull request Feb 29, 2024
* Create pattern-metrics.yaml

Getting started measuring pattern metrics. Related to InnerSourceCommons#565. 

This pull request implements
- Time to first response metrics for new issues (excluding codeowners created) recurring every month
- Time to first response metrics for new pull requests (excluding codeowners created) recurring every month
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ Type - Meta Improving how we collaborate in this repo is the main focus of this issue / PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants