Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wiki implementation of InnerSource portal pattern #637

Merged
merged 5 commits into from
Jan 2, 2024

Conversation

rrrutledge
Copy link
Contributor

No description provided.

Copy link
Member

@spier spier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff @rrrutledge!

This makes me want to find orgs that are using Backstage for this purpose, we know they exist, so that we can add this to your new Implementations section :)

patterns/2-structured/innersource-portal.md Outdated Show resolved Hide resolved
patterns/2-structured/innersource-portal.md Outdated Show resolved Hide resolved
* **Technology Pre-requisites**. You must use these technologies in order to on-board to the project.
* **Getting Started**. Link to instructions on how to start using the project.
* **Chat**. Link to a chat channel to ask questions about the project.
* **Sponsoring Team**. Seeing if a team is behind the project can help others to have the confidence to use it.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have seen "Maintaining Team" and "Host Team" for this in the ISC.

Is there a particular reason why you like "Sponsoring" better here?
e.g. are you worried that the "maintaining" emphasizes a notice of mine vs yours, and with that goes somewhat counter to the core idea of InnerSource?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to Host team. Yes - maintainer has some connotation that goes against parts of InnerSource.

patterns/2-structured/innersource-portal.md Outdated Show resolved Hide resolved
@spier spier added 2-structured Patterns with existing instances (Please see our contribution handbook for details) 📖 Type - Content Work Working on contents is the main focus of this issue / PR labels Dec 6, 2023
Copy link
Contributor Author

@rrrutledge rrrutledge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed all feedback. Thank you!

* **Technology Pre-requisites**. You must use these technologies in order to on-board to the project.
* **Getting Started**. Link to instructions on how to start using the project.
* **Chat**. Link to a chat channel to ask questions about the project.
* **Sponsoring Team**. Seeing if a team is behind the project can help others to have the confidence to use it.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to Host team. Yes - maintainer has some connotation that goes against parts of InnerSource.

patterns/2-structured/innersource-portal.md Show resolved Hide resolved
Copy link
Member

@spier spier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Let's deploy this, and see how the readers like it.

Who knows, maybe other patterns could benefit as well from splitting out such "Implementation" information into a separate section in the pattern.

patterns/2-structured/innersource-portal.md Show resolved Hide resolved
@spier
Copy link
Member

spier commented Jan 2, 2024

Note:
This PR also adds a new "Implementation" section to this pattern, which complements the "Solution" and "Known Instances" section.

Will be interesting to see how this benefits our readers. Who knows, maybe other patterns could benefit as well from splitting out such "Implementation" information into a separate section in the pattern.

@spier spier merged commit 64b4c36 into main Jan 2, 2024
9 of 11 checks passed
@spier spier deleted the rrrutledge-patch-1 branch January 2, 2024 14:39
@spier spier added the 🐅 patterns-in-the-wild InnerSource patterns that were spotted in the wild. We can extract Known Instances and new patterns. label Jan 2, 2024
@spier
Copy link
Member

spier commented Jan 2, 2024

@rrrutledge this is live now! https://patterns.innersourcecommons.org/p/innersource-portal#implementations

The formatting of this new content in gitbook looks a bit strange. Apparently gitbook formats the h4 headers the same way as h3. Not a big deal though, let's just leave it as is for now.

rmarting pushed a commit to rmarting/InnerSourcePatterns that referenced this pull request Feb 29, 2024
…mons#637)

Add wiki implementation of InnerSource portal pattern. To structure the information more clearly, this adds a new "Implementation" section to this pattern, which complements the "Solution" and "Known Instances" section.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2-structured Patterns with existing instances (Please see our contribution handbook for details) 📖 Type - Content Work Working on contents is the main focus of this issue / PR 🐅 patterns-in-the-wild InnerSource patterns that were spotted in the wild. We can extract Known Instances and new patterns.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants