Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Pattern: Code of Conduct #661

Merged
merged 12 commits into from
Jun 13, 2024

Conversation

rmarting
Copy link
Contributor

@rmarting rmarting commented Mar 5, 2024

As part of the discussions about adding a new Code of Conduct template in the Standard Base Documentation (#555 and #556) and some research, this PR includes the proposal of a new Pattern in the collection: Code of Conduct.

This pattern wants to cover the space of an InnerSource community/product for healthy and inclusive discussions across different individuals and teams inside of the organization.

It is open for discussion, extending the previous ones and open for more people.

@rmarting
Copy link
Contributor Author

rmarting commented Mar 5, 2024

@spier @mcobby Hopefully you can check and review this first version of the Code of Conduct pattern. Feel free to add comments, ideas, or fixing typos to improve it.

Thanks

@spier spier changed the title New Patternr: Code of Conduct New Pattern: Code of Conduct Mar 5, 2024
@spier spier added 1-initial Donuts, Early pattern ideas, ... (Please see our contribution handbook for details) 📖 Type - Content Work Working on contents is the main focus of this issue / PR labels Mar 8, 2024
@spier
Copy link
Member

spier commented Mar 8, 2024

@rmarting thanks for this new PR!

For now I just sent some formatting fixes, making it easier for other reviews (and me) to provide inline suggestions on GitHub. Hope you don't mind that I pushed this straight to your branch.

Hope to review the content of the pattern some time this weekend as well.

Copy link
Member

@spier spier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rmarting.

Once again, thanks so much for sharing your thoughts with us here.

The sections that new pattern contributors often find the hardest are the Context and Forces sections. So don't be disheartened if it can take a while to wrap your head around those concepts. This video contains helpful explanation about those concepts.

I left most of my comments inline.

However I had two general thoughts that I want to share:

  • Is there a general description of the goals of a CoC that we can link to? (typically these references come from the open source world)
  • What happens when the CoC is broken? Is that something that could be added to the solution or implementation section? Here is an a conference talk related to this that I once heard, and also the Mozilla Community Participation Guidelines contain something about the reporting process in case of a CoC violation. Again this point might be different in InnerSource than in open source, and therefore even more valuable to describe as part of this pattern.

Hope you find this review helpful, and I am happy to answer any questions and help you through the rest of the process of getting this contribution added to our repo.

You rock 🤘

patterns/1-initial/code-of-conduct.md Outdated Show resolved Hide resolved
patterns/1-initial/code-of-conduct.md Show resolved Hide resolved
patterns/1-initial/code-of-conduct.md Show resolved Hide resolved
patterns/1-initial/code-of-conduct.md Show resolved Hide resolved
patterns/1-initial/code-of-conduct.md Show resolved Hide resolved
patterns/1-initial/code-of-conduct.md Outdated Show resolved Hide resolved
patterns/1-initial/code-of-conduct.md Show resolved Hide resolved
patterns/1-initial/code-of-conduct.md Outdated Show resolved Hide resolved
patterns/1-initial/code-of-conduct.md Outdated Show resolved Hide resolved
patterns/1-initial/code-of-conduct.md Show resolved Hide resolved
@spier
Copy link
Member

spier commented Mar 11, 2024

Hi @discombobulateme, I was wondering if you have heard about a Code of Conduct in the context of an InnerSource project before? Curious to hear your thoughts on the applicability of the concept outside of the open source or open community domain. Feel free to leave a comment here or add in line thoughts to this PR, whatever works for you.

Any time you can spare, we would appreciate so much! :)

@spier
Copy link
Member

spier commented Mar 11, 2024

Also I found the slides from the amazing The code of conduct has been broken talk I had already mentioned before.

Possibly we could borrow the idea from slide 11 for an illustration for your pattern here?

@discombobulateme
Copy link

discombobulateme commented Mar 11, 2024 via email

Copy link
Contributor Author

@rmarting rmarting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spier Just followed your suggestions and I updated the content with new material that hopefully fits all your ideas.

patterns/1-initial/code-of-conduct.md Show resolved Hide resolved
patterns/1-initial/code-of-conduct.md Show resolved Hide resolved
patterns/1-initial/code-of-conduct.md Show resolved Hide resolved
patterns/1-initial/code-of-conduct.md Show resolved Hide resolved
patterns/1-initial/code-of-conduct.md Show resolved Hide resolved
@rmarting
Copy link
Contributor Author

rmarting commented Jun 5, 2024

@spier Any update/feedback to move forward? What should be the next step? Thanks

@spier
Copy link
Member

spier commented Jun 6, 2024

@rmarting my bad. Dropped the ball on this one. Will try to review this weekend.

Feel free to ping me again, these are good reminders :)

Copy link
Member

@spier spier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rmarting.

I like what you did here, and would be happy to merge as is already.

I made a couple of inline suggestions that you can use as you see fit i.e. either use some of them, or even ignore them entirely for the time being.

In any case, I would be happy to merge your PR here shortly, so that we can get the pattern added to the repo. This will allow us to share it more widely and hopefully get further feedback.

Thank you again for your patience and help in making our patterns collection better!

patterns/1-initial/code-of-conduct.md Show resolved Hide resolved
patterns/1-initial/code-of-conduct.md Show resolved Hide resolved
patterns/1-initial/code-of-conduct.md Outdated Show resolved Hide resolved
patterns/1-initial/code-of-conduct.md Show resolved Hide resolved
patterns/1-initial/code-of-conduct.md Show resolved Hide resolved
rmarting and others added 3 commits June 12, 2024 22:55
By spier suggestion

Co-authored-by: Sebastian Spier <[email protected]>
By spier suggestion

Co-authored-by: Sebastian Spier <[email protected]>
Copy link
Contributor Author

@rmarting rmarting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @spier for your good feedbak! I added some minor changes aligned with your comments, please, take a look.

Glad to know that we are very near to aprove this PR and add this pattern into the catalog. Thank you so much for all your support and collaboration.

patterns/1-initial/code-of-conduct.md Show resolved Hide resolved
patterns/1-initial/code-of-conduct.md Show resolved Hide resolved
@rmarting
Copy link
Contributor Author

rmarting commented Jun 12, 2024

Just another question: Should I update the README.md file at the root to add this pattern in the Maturity Level 1: Initial block? Or is it something that you usually do after the PR is merged?
Thanks

Well, I did it! :)

@spier
Copy link
Member

spier commented Jun 13, 2024

@rmarting looks great!

Let me know when you want me to hit the MERGE button :)

@rmarting
Copy link
Contributor Author

Cool!! 🎉 I am ready to go!!! Thank you so much!!!

@spier spier merged commit cefbaea into InnerSourceCommons:main Jun 13, 2024
8 checks passed
Copy link

welcome bot commented Jun 13, 2024

Congratulations Banner
Congrats on merging your first pull request! 🎉 We here at The InnerSource Commons are proud of you! 💖 Thank you so much for your contribution 🎁

@spier
Copy link
Member

spier commented Jun 13, 2024

Excellent work @rmarting. Your pattern is in the mainline now.
Looks great! 🔥

https://github.com/InnerSourceCommons/InnerSourcePatterns/blob/main/patterns/1-initial/code-of-conduct.md

Will share this in slack as well, and see if we can get more feedback for it over time.
At some point we can revisit it see if we feel it is ready to be published in the online book.
There is no rush to do that though.

@rmarting rmarting deleted the new-code-of-conduct-pattern branch June 13, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-initial Donuts, Early pattern ideas, ... (Please see our contribution handbook for details) 📖 Type - Content Work Working on contents is the main focus of this issue / PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants