-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Pattern: Code of Conduct #661
New Pattern: Code of Conduct #661
Conversation
…wing inline suggestions on GitHub.
…he published online book automatically.
@rmarting thanks for this new PR! For now I just sent some formatting fixes, making it easier for other reviews (and me) to provide inline suggestions on GitHub. Hope you don't mind that I pushed this straight to your branch. Hope to review the content of the pattern some time this weekend as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rmarting.
Once again, thanks so much for sharing your thoughts with us here.
The sections that new pattern contributors often find the hardest are the Context and Forces sections. So don't be disheartened if it can take a while to wrap your head around those concepts. This video contains helpful explanation about those concepts.
I left most of my comments inline.
However I had two general thoughts that I want to share:
- Is there a general description of the goals of a CoC that we can link to? (typically these references come from the open source world)
- What happens when the CoC is broken? Is that something that could be added to the solution or implementation section? Here is an a conference talk related to this that I once heard, and also the Mozilla Community Participation Guidelines contain something about the reporting process in case of a CoC violation. Again this point might be different in InnerSource than in open source, and therefore even more valuable to describe as part of this pattern.
Hope you find this review helpful, and I am happy to answer any questions and help you through the rest of the process of getting this contribution added to our repo.
You rock 🤘
Hi @discombobulateme, I was wondering if you have heard about a Code of Conduct in the context of an InnerSource project before? Curious to hear your thoughts on the applicability of the concept outside of the open source or open community domain. Feel free to leave a comment here or add in line thoughts to this PR, whatever works for you. Any time you can spare, we would appreciate so much! :) |
Also I found the slides from the amazing The code of conduct has been broken talk I had already mentioned before. Possibly we could borrow the idea from slide 11 for an illustration for your pattern here? |
Hi Sebastian :)
Ohhh how sweet of you :)
Please remix it! And let me know your takes, this is an ongoing
conversation :)
I like to see our internal as our first community, and I understand the
code of conduct, in the case of a company, needs to be verified with HR, as
it implies a bit more strict laws, especially in a global context.
In case you would like to exchange some experiences I would love to :)
A warm regard,
Paloma
…On Mon, Mar 11, 2024 at 10:19 PM Sebastian Spier ***@***.***> wrote:
Also I found the slides
<https://docs.google.com/presentation/d/1cNxHbvtxooB3PTUI1xwb7PA_BYVsj_ZvOenbXWaOiH8/edit#slide=id.g17a2e204e59_0_90>
from the amazing The code of conduct has been broken
<https://www.youtube.com/watch?v=RBZrYMEJFXA&list=PLq-odUc2x7i9Zrs4oyM1I3V5xlYICEL2g&index=8>
talk I had already mentioned before.
Possibly we could borrow the idea from slide 11 for an illustration for
your pattern here?
—
Reply to this email directly, view it on GitHub
<#661 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB44MUFOK6IKF3BAPO3SQD3YXYNUXAVCNFSM6AAAAABEGR2BNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBZGQ3DENZSHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Paloma Oliveira
Growth Engineer
***@***.***
www.saucelabs.com
Sauce Labs Europe GmbH
Warschauer Platz 11-13 I 10245 Berlin I Germany
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@spier Just followed your suggestions and I updated the content with new material that hopefully fits all your ideas.
@spier Any update/feedback to move forward? What should be the next step? Thanks |
@rmarting my bad. Dropped the ball on this one. Will try to review this weekend. Feel free to ping me again, these are good reminders :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rmarting.
I like what you did here, and would be happy to merge as is already.
I made a couple of inline suggestions that you can use as you see fit i.e. either use some of them, or even ignore them entirely for the time being.
In any case, I would be happy to merge your PR here shortly, so that we can get the pattern added to the repo. This will allow us to share it more widely and hopefully get further feedback.
Thank you again for your patience and help in making our patterns collection better!
By spier suggestion Co-authored-by: Sebastian Spier <[email protected]>
By spier suggestion Co-authored-by: Sebastian Spier <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @spier for your good feedbak! I added some minor changes aligned with your comments, please, take a look.
Glad to know that we are very near to aprove this PR and add this pattern into the catalog. Thank you so much for all your support and collaboration.
Well, I did it! :) |
@rmarting looks great! Let me know when you want me to hit the MERGE button :) |
Cool!! 🎉 I am ready to go!!! Thank you so much!!! |
Excellent work @rmarting. Your pattern is in the mainline now. Will share this in slack as well, and see if we can get more feedback for it over time. |
As part of the discussions about adding a new Code of Conduct template in the Standard Base Documentation (#555 and #556) and some research, this PR includes the proposal of a new Pattern in the collection: Code of Conduct.
This pattern wants to cover the space of an InnerSource community/product for healthy and inclusive discussions across different individuals and teams inside of the organization.
It is open for discussion, extending the previous ones and open for more people.