-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n Foundation and adding Japanese pages #425
Conversation
…sian, and the LearningPath to support all languages
…sian, and the LearningPath to support all languages
…mons.org into japanese-pages
…ese is a language without spaces
Except for heroku slack inviter and some original broken pages, linkcheck has already succeeded. No Japanese-specific problems exist. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Million thanks for the huge work you're doing!
Some comments before the merge:
Looks like the last item in the menu still untranslated.
Also noticed a bug (imho can leave for now but then to not to forget to do smth):
- Go to learning path.
- Change language to German (or other except
en
andja
). - Go to home page.
Language parameter continue to be German, but content is rsynced
from English. If we change the language again, German option will be hidden. This was handled correctly previously when there are no pages was autogenerated from english but now we may consider another behaviour. I'm expect to live a long time without translation to all languages :)
config/_default/menus.ru.yaml
Outdated
@@ -1,123 +1,116 @@ | |||
main: | |||
- name: Learn | |||
- name: Учиться |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Обучение
config/_default/menus.ru.yaml
Outdated
parent: learn | ||
URL: ru/learn/books | ||
weight: 2 | ||
- name: Learning Path | ||
- name: Путь обучения |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Программа обучения
config/_default/menus.ru.yaml
Outdated
parent: learn | ||
URL: ru/learn/learning-path | ||
weight: 3 | ||
- name: Patterns | ||
- name: Шаблоны |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Паттерны
config/_default/menus.ru.yaml
Outdated
URL: ru/stories | ||
weight: 4 | ||
- name: Services Directory | ||
- name: Справочник услуг |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Каталог услуг
config/_default/menus.ru.yaml
Outdated
URL: ru/about/codeofconduct | ||
parent: about | ||
weight: 5 | ||
- name: Contact Us | ||
- name: Свяжитесь с нами |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Контакты
config/_default/menus.ru.yaml
Outdated
URL: ru/about/contact | ||
parent: about | ||
weight: 6 | ||
footer_left: | ||
- name: Learn | ||
- name: Учиться |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Обучение
config/_default/menus.ru.yaml
Outdated
URL: ru/stories | ||
weight: 3 | ||
post: bold | ||
- name: Services Directory | ||
- name: Справочник услуг |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Каталог услуг
config/_default/menus.ru.yaml
Outdated
URL: ru/about/board | ||
weight: 2 | ||
- name: Members | ||
- name: Члены |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Участники
config/_default/menus.ru.yaml
Outdated
URL: ru/about/codeofconduct | ||
weight: 5 | ||
- name: Contact Us | ||
- name: Свяжитесь с нами |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Контакты
@voborgus It would be very stressful if, when viewing a German page, the user had to leave that locale every time they went to an untranslated page. The user would be taken unawares to an untranslated page, but if they were taken to a In many cases, for example in the case of Microsoft documentation, there are each types of pages available, even if they are not translated, as follows So far, there are 27 markdown files under content/ja, since there are 100+ markdown files under content/en. And since rsync is supposed to skip files that exist, there is no need to translate all pages or even add them to the codebase. wdyt? |
You right, let's leave it for now – then we may decide other behaviour based on users feedback. So small translation fixes left and ready to merge 👍🏻 |
…mons.org into japanese-pages
@voborgus Could you merge it now?! |
Again, the staging page is live now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Lets merge it
Amazing!!! |
@voborgus @InnerSourceCommons/website-maintainers
I have created a Japanese page on innersourcecommons.org, and there is a staging site at innersourcecommons.jp.
Please check and merge it:)
Now that we have this foundation in place, the next step may be to translate the materials into German, Russian, etc. I will create branches and make a base in the future to try it out after this PR is successfully merged.
There are still some issues with integration with Learning Path: all Learning Path materials now reside under content/en/, and they are moved correctly when gh-pages are created, so it doesn't essentially affect functionality. It's not pretty though, so I'll fix that in the future.
For more info, please check the issue #355