Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n Foundation and adding Japanese pages #425

Merged
merged 43 commits into from
Dec 23, 2022
Merged

i18n Foundation and adding Japanese pages #425

merged 43 commits into from
Dec 23, 2022

Conversation

yuhattor
Copy link
Member

@yuhattor yuhattor commented Dec 13, 2022

@voborgus @InnerSourceCommons/website-maintainers
I have created a Japanese page on innersourcecommons.org, and there is a staging site at innersourcecommons.jp.
Please check and merge it:)

Now that we have this foundation in place, the next step may be to translate the materials into German, Russian, etc. I will create branches and make a base in the future to try it out after this PR is successfully merged.

There are still some issues with integration with Learning Path: all Learning Path materials now reside under content/en/, and they are moved correctly when gh-pages are created, so it doesn't essentially affect functionality. It's not pretty though, so I'll fix that in the future.

For more info, please check the issue #355

@yuhattor yuhattor added the enhancement New feature or request label Dec 13, 2022
@yuhattor yuhattor requested a review from a team as a code owner December 13, 2022 02:46
@yuhattor
Copy link
Member Author

Except for heroku slack inviter and some original broken pages, linkcheck has already succeeded. No Japanese-specific problems exist.

Copy link
Collaborator

@voborgus voborgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Million thanks for the huge work you're doing!

Some comments before the merge:

Looks like the last item in the menu still untranslated.

image

Also noticed a bug (imho can leave for now but then to not to forget to do smth):

  • Go to learning path.
  • Change language to German (or other except en and ja).
  • Go to home page.

Language parameter continue to be German, but content is rsynced from English. If we change the language again, German option will be hidden. This was handled correctly previously when there are no pages was autogenerated from english but now we may consider another behaviour. I'm expect to live a long time without translation to all languages :)

content/ja/about/_index.md Outdated Show resolved Hide resolved
@@ -1,123 +1,116 @@
main:
- name: Learn
- name: Учиться
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Обучение

parent: learn
URL: ru/learn/books
weight: 2
- name: Learning Path
- name: Путь обучения
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Программа обучения

parent: learn
URL: ru/learn/learning-path
weight: 3
- name: Patterns
- name: Шаблоны
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Паттерны

URL: ru/stories
weight: 4
- name: Services Directory
- name: Справочник услуг
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Каталог услуг

URL: ru/about/codeofconduct
parent: about
weight: 5
- name: Contact Us
- name: Свяжитесь с нами
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Контакты

URL: ru/about/contact
parent: about
weight: 6
footer_left:
- name: Learn
- name: Учиться
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Обучение

URL: ru/stories
weight: 3
post: bold
- name: Services Directory
- name: Справочник услуг
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Каталог услуг

URL: ru/about/board
weight: 2
- name: Members
- name: Члены
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Участники

URL: ru/about/codeofconduct
weight: 5
- name: Contact Us
- name: Свяжитесь с нами
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Контакты

@yuhattor
Copy link
Member Author

yuhattor commented Dec 13, 2022

@voborgus
This is a matter for debate. Actually, this move is done this way by design

It would be very stressful if, when viewing a German page, the user had to leave that locale every time they went to an untranslated page. The user would be taken unawares to an untranslated page, but if they were taken to a /en (Default) page, they would have to revert to their own language each time.

In many cases, for example in the case of Microsoft documentation, there are each types of pages available, even if they are not translated, as follows
https://azure.microsoft.com/ja-jp/updates/public-preview-v2-programming-model-for-azure-functions-using-python/
https://azure.microsoft.com/en-us/updates/public-preview-v2-programming-model-for-azure-functions-using-python/

So far, there are 27 markdown files under content/ja, since there are 100+ markdown files under content/en. And since rsync is supposed to skip files that exist, there is no need to translate all pages or even add them to the codebase.
Let's say someone wants to translate only a minimum of 10 .md files, including the top page, in a new language, he/she doesn't have to translate the whole thing.

wdyt?

@voborgus
Copy link
Collaborator

You right, let's leave it for now – then we may decide other behaviour based on users feedback.

So small translation fixes left and ready to merge 👍🏻

@yuhattor
Copy link
Member Author

@voborgus Could you merge it now?!
I fixed the small menu mistranslation in Russian and all checks have passed:)

@yuhattor
Copy link
Member Author

Again, the staging page is live now
https://innersourcecommons.jp/ru/learn/learning-path/

Copy link
Collaborator

@voborgus voborgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Lets merge it

@voborgus voborgus merged commit a373223 into master Dec 23, 2022
@voborgus voborgus deleted the japanese-pages branch December 23, 2022 09:30
@yuhattor
Copy link
Member Author

Amazing!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants