Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/enhancedlogging #156

Merged
merged 25 commits into from
Aug 15, 2024
Merged

Feature/enhancedlogging #156

merged 25 commits into from
Aug 15, 2024

Conversation

cheinamann
Copy link
Collaborator

@cheinamann cheinamann commented Aug 9, 2024 •
edited
Loading

  1. The logging lakehouse can be set in the profile "log_lakehouse: LOG LAKEHOUSE HERE". The profile creation will ask for this now. This will need to be added to the documentation.
  2. Both logging tables include the master notebook as a column.
  3. The logging code has been amended to include the master notebook when opening and closing batches
  4. Datetime is now in human readable format but in UTC time. This can have the timezone added when writing queries against the data.

#50

cheinamann added 19 commits August 7, 2024 15:21
@cheinamann
Made the changes to apply a different lakehouse for logging if select…
fbcc82f 
…ed as an option in the wrapper #50
@cheinamann
Updated the Logs to include the master notebook being used for the ex…
050ac0a 
…ecution and included this in the batch and log queries. #50
@cheinamann
Updated the notebooks to make the timestamps human readable formatted…
0e7b01a 
…. Timestamps are in UTC. #50
@cheinamann
Fixing error where default is not being populated for log lakehouse
4785d09
@cheinamann
Updated code to fix the child notebook log lakehouse
85db4b5
@cheinamann
Changed the log lakehouse from an option in the wrapper to a config i…
3a3323f 
…n the profile.yml #50
@cheinamann
Added a fix for the child notebooks. #50
7754743
@cheinamann
Fixed a log lakehouse reference. #50
fe0959b
@cheinamann
Fixed a log error #50
3a30b35
@cheinamann
Fixed batch logging error #50
bafd247
@cheinamann
Added code that will not fail the log lakehouse default if the profil…
1bbcf98 
…e value is not set #50
@cheinamann
Added config for log_lakehouse in profile setup #50
b7b6784
@cheinamann
Added the log_lakehouse to the template. #50
fc94b89
@cheinamann
Added a check for log_lakehouse in profile create #50
7f92d44
@cheinamann
Removed the parameter for child notebooks for the log lakehouse. #50
22dcccf
@cheinamann
Fixed a notebook reference #50
d3d7a6a
@cheinamann
Fixed code error #50
c52b1c7
@cheinamann
Merge dev to feature
8a49555
@cheinamann
Fixed a code error #50
43d157d
grantkriegerai
grantkriegerai approved these changes Aug 15, 2024
View reviewed changes
Copy link
Collaborator

@grantkriegerai grantkriegerai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good tested

@grantkriegerai grantkriegerai merged commit c43e3a8 into dev Aug 15, 2024
3 checks passed
@grantkriegerai grantkriegerai deleted the feature/enhancedlogging branch August 15, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grantkriegerai grantkriegerai grantkriegerai approved these changes

Assignees

@annstephyjose annstephyjose

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cheinamann @grantkriegerai @annstephyjose