Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(create-web-worker): allow undefined workerUrl #1105

Merged
merged 1 commit into from
Apr 10, 2024
Merged

fix(create-web-worker): allow undefined workerUrl #1105

merged 1 commit into from
Apr 10, 2024

Conversation

floryst
Copy link
Member

@floryst floryst commented Apr 10, 2024

Calling createWebWorker() with an undefined pipelineWorkerUrl should be equivalent to passing in null.

@floryst floryst requested a review from thewtex April 10, 2024 18:02
@floryst floryst force-pushed the fix-create-web-worker-null branch from bdabcef to cdd95a4 Compare April 10, 2024 18:02
thewtex
thewtex approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@floryst thanks!

Other CI issues should be unrelated.

@thewtex thewtex merged commit e489ad6 into main Apr 10, 2024
148 of 249 checks passed
@thewtex thewtex deleted the fix-create-web-worker-null branch April 10, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewtex thewtex thewtex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@floryst @thewtex