Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image IO componentType, pixelType options #682

Merged
merged 11 commits into from
Nov 8, 2022
Merged

Image IO componentType, pixelType options #682

merged 11 commits into from
Nov 8, 2022

Conversation

thewtex
Copy link
Member

@thewtex thewtex commented Nov 4, 2022

  • pixelType and componentType options to image IO functions
  • Same option object conventions as other pipeline functions. Existing options arguments still supported through backwards compatibility code.

@thewtex
Copy link
Member Author

thewtex commented Nov 6, 2022

Closes #671

@thewtex thewtex marked this pull request as ready for review November 7, 2022 22:32
sankhesh
sankhesh approved these changes Nov 8, 2022
View reviewed changes
Copy link
Collaborator

@sankhesh sankhesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall except that one question

src/io/readImageDICOMArrayBufferSeries.ts Show resolved Hide resolved
@thewtex thewtex merged commit 7f9a0a9 into InsightSoftwareConsortium:main Nov 8, 2022
@thewtex thewtex deleted the io-cast-image branch November 8, 2022 21:27
@github-actions
Copy link

github-actions bot commented Nov 8, 2022

🎉 This PR is included in version 1.0.0-b.49 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sankhesh sankhesh sankhesh approved these changes

@jadh4v jadh4v Awaiting requested review from jadh4v

@FezVrasta FezVrasta Awaiting requested review from FezVrasta

Assignees
No one assigned
Labels
released on @beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thewtex @sankhesh