refac(itk-dicom): refactor itk-dicom as package #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thewtex Should this line be removed to updated to the new path? |
jadh4v
force-pushed
the
ENH-migrate-dicom-module-to-separate-package
branch
2 times, most recently
from
ee8f4fc to
46ef37f
Compare
jadh4v
commented
Feb 9, 2023
| <script type="module" src="./dist/itk-dicom.js"></script> | ||
| <script type="module" src="./dist/demo/app.js"></script> | ||
| <script type="module" src="./dist/bundles/itk-dicom.js"></script> | ||
| <script type="module" src="./test/browser/app.ts"></script> |
There was a problem hiding this comment.
We are changing dist/demo/app.js to test/browser/app.ts but this is a demo and not an automated browser test. Is this really correct?
There was a problem hiding this comment.
It is both a demo and the basis for tests with Cypress.
thewtex
approved these changes
Feb 9, 2023
|
🎉 This PR is included in version 1.0.0-b.68 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.