Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Examples): Add different-input-types examples #746

Merged

Conversation

thewtex
Copy link
Member

@thewtex thewtex commented Jan 31, 2023

Demonstrates how to create a pipeline that accepts two different input image types.

Copy link
Collaborator

@PaulHax PaulHax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very helpful.

The wasi-build directory is not in .gitignore.

return itk::wasm::SupportInputImageTypes<InputImagePipelineFunctor,
uint8_t,
uint16_t>
::Dimensions<2U>("input-image", pipeline);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I add a third Dimension
::Dimensions<2U, 3U>("input-image", pipeline);
I get compile errors.

How can I narrow down the TImage and TLabelImage dimension to just be matching?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! Let's fix the second image dimension to the first image dimension as a best practice. Also adding .gitignore.

Demonstrates how to create a pipeline that accepts two different input
image types.
@thewtex thewtex force-pushed the different-input-types branch from 2ebbd1d to 0f02eb8 Compare February 1, 2023 21:41
@thewtex thewtex merged commit 0e37262 into InsightSoftwareConsortium:main Feb 6, 2023
@thewtex thewtex deleted the different-input-types branch February 6, 2023 03:13
@github-actions
Copy link

github-actions bot commented Feb 6, 2023

🎉 This PR is included in version 1.0.0-b.67 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants