Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WASI long double flag #748

Merged
merged 2 commits into from
Feb 7, 2023
Merged

Add WASI long double flag #748

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6634822
build(wasi): Add support for printscan-long-double
thewtex Feb 6, 2023
89b7886
feat(itk-wasm-cli): Update default Docker image for 20230206-66348225
thewtex Feb 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,8 @@ FetchContent_Declare(
)

set(CLI11_GIT_REPOSITORY "https://github.com/CLIUtils/CLI11")
# std::strtold patch
set(CLI11_GIT_REPOSITORY "https://github.com/thewtex/CLI11")
set(CLI11_GIT_TAG "82d4e022cdfcf18d1fc59684bdc6977ea34053f4")
# v2.3.2
set(CLI11_GIT_TAG "291c58789c031208f08f4f261a858b5b7083e8e2")
FetchContent_Declare(
cli11
GIT_REPOSITORY ${CLI11_GIT_REPOSITORY}
Expand Down
4 changes: 2 additions & 2 deletions src/docker/itk-wasm-base/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,13 @@ for param; do
done
set -- "${newparams[@]}" # overwrites the original positional params

wasi_ld_flags="-flto -lwasi-emulated-process-clocks -lwasi-emulated-signal"
wasi_ld_flags="-flto -lwasi-emulated-process-clocks -lwasi-emulated-signal -lc-printscan-long-double"
wasi_c_flags="-flto -D_WASI_EMULATED_PROCESS_CLOCKS -D_WASI_EMULATED_SIGNAL"

emscripten_debug_ld_flags="-fno-lto -s ALLOW_MEMORY_GROWTH=1"
emscripten_debug_c_flags="-fno-lto -Wno-warn-absolute-paths"

wasi_debug_ld_flags="-fno-lto -lwasi-emulated-process-clocks -lwasi-emulated-signal"
wasi_debug_ld_flags="-fno-lto -lwasi-emulated-process-clocks -lwasi-emulated-signal -lc-printscan-long-double"
wasi_debug_c_flags="-fno-lto -D_WASI_EMULATED_PROCESS_CLOCKS -D_WASI_EMULATED_SIGNAL"

docker build -t itkwasm/emscripten-base:latest \
Expand Down
2 changes: 1 addition & 1 deletion src/itk-wasm-cli.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const program = new Command()

// Array of types that will require an import from itk-wasm
const typesRequireImport = ['Image']
const defaultImageTag = '20230201-d4552761'
const defaultImageTag = '20230206-66348225'

function processCommonOptions() {
const options = program.opts()
Expand Down