PERF: Make ImageRegion trivially copyable (LEGACY_REMOVE)
#4691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced `ITK_FUTURE_LEGACY_REMOVE` with `ITK_LEGACY_REMOVE`, regarding its inheritance from `itk::Region`. A run-time performance improvement of more than 25% on default-constructing and destructing a sequence of `ImageRegion` objects was observed. - Follow-up to pull request InsightSoftwareConsortium#4344 commit 1f3bbb6
github-actions
bot
added
type:Performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced
ITK_FUTURE_LEGACY_REMOVEwithITK_LEGACY_REMOVE, regarding its inheritance fromitk::Region.A run-time performance improvement of more than 25% on default-constructing and destructing a sequence of
ImageRegionobjects was observed.ImageRegiontrivially copyable, remove inheritance (ITK_FUTURE_LEGACY_REMOVE) #4344 commit 1f3bbb6