-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
problem with composer >= 2.0.9 #36
Comments
Unfortunately, the problem still not clear to me. Which scanner config you use? Are you install scanner globally, with composer global require? What is slow - composer work, or scanner work? |
the problem exists not because of this project, i am not even using this scanner. i just wanted to let you know, that your project uses a project that uses a project that behaves differently based on the composer version, that´s all. as said, if this don´t bother you, it´s absolutely fine, i just wanted to let you know where the plugin - in my special case - is coming from ;) |
Ah, I understand, thanks |
to be clear: your package IS installed in my project, but i didn´t use the scanner since a long time. but because this special plugin made me nuts... i was looking inside the dependency tree, where this plugin is coming from. and the result u see in my first posting ;) |
it looks like the "update helper" is removed inside carbon since version 1.4.0. |
@michabbb IMO this should be reported to https://github.com/kylekatarnls/update-helper - as it seems to do something which misbehaves with Composer 2.0.9+. I have no idea what they are doing in that project but if the project author figures out the issue I'm happy to help out from the Composer side of things. Feel free to cc me on the issue if you create one. @Insolita IMO this can be closed and I don't think you necessarily need to remove Carbon, but maybe you should allow carbon 2.x usage so at least people on modern PHP versions do not get stuck with this update helper dependency. I guess for @michabbb it wouldn't help if using PHP 5.6 is a requirement. |
Honestly, Carbon dependency is not so necessary, native Datetime will be enough |
Yeah if you can get rid of it that's fine too of course, but that won't fix the root cause in the update-helper project (which is installed a lot probably due to all Carbon 1.x users). |
hi there,
my apologies in case I am totally wrong here.
i am using this package with version with "^1.3" inside my composer.json with PHP 5.6.9 as fixed PHP version. (yeah i know, super old).
i was wondering, why composer now takes minutes instead of seconds when just using composer with
-h
- so with nothing.turned out, that this package uses
nesbot/carbon (>=1.22)
and this package requireskylekatarnls/update-helper (^1.1)
.and the helper is scanning all my files, while composer <= 2.0.8 is not.
i don´t know what really causes that behavior, but in case it has something to do with this package i wanted to let you know.
thanks !
composer/composer#9760
The text was updated successfully, but these errors were encountered: