Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scanning all files with composer >= 2.0.9 #12

Closed
michabbb opened this issue Mar 9, 2021 · 3 comments
Closed

scanning all files with composer >= 2.0.9 #12

michabbb opened this issue Mar 9, 2021 · 3 comments

Comments

@michabbb
Copy link

michabbb commented Mar 9, 2021

composer/composer#9760 (comment)

Insolita/unused-scanner#36

dear maintainer, there is something strange with that package, since composer version 2.0.9.

please take a look.

thank you.

@kylekatarnls
Copy link
Owner

Hello,

First move I can advise is upgrading to Carbon ^2 (2.0.0 was out in August 2018). As Carbon end of life is over for more than a year, de advise we won't spend too much effort in making this dead package working with modern composer version.

Then, update-helper on its own does not scan all files, only each composer.json which indeed could be slow with a lot of packages and a slow file system. But this would not be impacted by the version of composer in use.

If you would have a stack trace (an identified bottleneck from some profilling dump), it might help to know which composer function/method became slow on 2.0.9. From this point I could eventually propose a fix to composer or try to use something else faster instead.

@michabbb
Copy link
Author

hi, i have a php7 project and used different composer versions with the same composer.json - and it turned out, that from version 2.0.9 composer was scanning every single file of my project, while 2.0.8 did not. the only composer plugin that exists in my project, is "update-helper" and starting composer with "--disable-plugin" worked fine again. that´s all i can say. but as u mentioned, the version i am talking about - from this package - is old. and i already changed the version of the "unsued-scanner", so in fact, this whole thing is no longer an issue for me. i just wanted to mention it here, in case u are interested in and want to look into it. if you want, you can lose this issue.

@kylekatarnls
Copy link
Owner

kylekatarnls commented Mar 18, 2021

Yes without more clue on this, it would be finding a needle in a haystack, and I don't feel it's worth it regarding the low reproduction rate of the issue. Thanks for letting know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants