Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for adding w3c header #21

Merged
merged 19 commits into from
Nov 18, 2024
Merged

feat: add support for adding w3c header #21

merged 19 commits into from
Nov 18, 2024

Conversation

ahmedAlaaInstabug
Copy link
Contributor

Description of the change

  1. add Support for w3cHeader

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

JIRA ID: MOB-14532

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@ahmedAlaaInstabug ahmedAlaaInstabug self-assigned this Jul 24, 2024
@a7medev a7medev changed the title feat/Add support for adding w3cHeader feat: add support for adding w3c header Aug 20, 2024
a7medev
a7medev requested changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@a7medev a7medev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like the code for getting the W3C header and populating it is duplicated throughout all the HTTP methods, can we refactor this somehow?

CHANGELOG.md Outdated Show resolved Hide resolved
a7medev
a7medev previously approved these changes Nov 6, 2024
View reviewed changes
@mzelzoghbi mzelzoghbi merged commit 4952b89 into master Nov 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzelzoghbi mzelzoghbi mzelzoghbi approved these changes

@a7medev a7medev Awaiting requested review from a7medev

@AndrewAminInstabug AndrewAminInstabug Awaiting requested review from AndrewAminInstabug

Assignees

@ahmedAlaaInstabug ahmedAlaaInstabug

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ahmedAlaaInstabug @mzelzoghbi @a7medev @AndrewAminInstabug