Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MOB-12609] Unify Discard Alert Buttons Strings #1001

Merged
merged 3 commits into from
Jul 18, 2023
Merged

[MOB-12609] Unify Discard Alert Buttons Strings #1001

merged 3 commits into from
Jul 18, 2023

Conversation

a7medev
Copy link
Contributor

@a7medev a7medev commented Jul 18, 2023

Description of the change

  • Deprecate the old discardAlertCancel and discardAlertAction string keys as they had inconsistent behavior between iOS and Android.
  • Introduce unified replacements for the deprecated strings (discardAlertStay and discardAlertDiscard).

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Issue links go here

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@a7medev a7medev self-assigned this Jul 18, 2023
@a7medev a7medev changed the base branch from master to dev July 18, 2023 08:11
@InstabugCI
Copy link
Collaborator

Coverage Report

Label Coverage Status
JavaScript 96.5% ✅
Android 47.8% ✅
iOS 39.0% ✅

Generated by 🚫 dangerJS against 8d79fa3

asamiz
asamiz approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@asamiz asamiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is approval from my side, great job @a7medev

@a7medev a7medev merged commit 46cff11 into dev Jul 18, 2023
@a7medev a7medev deleted the refactor/discard-alert-strings branch July 18, 2023 13:04
HeshamMegid pushed a commit that referenced this pull request Sep 17, 2023
@a7medev @HeshamMegid
[MOB-12609] Unify Discard Alert Buttons Strings (#1001)
45451de 
* Unify discard alert strings

* Update Changelog

* Fix Android tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asamiz asamiz asamiz approved these changes

@abdelhamid-f-nasser abdelhamid-f-nasser Awaiting requested review from abdelhamid-f-nasser

Assignees

@a7medev a7medev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a7medev @InstabugCI @asamiz