Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MOB-12640] Unify Repro Steps List Item Title String #1002

Merged
merged 6 commits into from
Jul 25, 2023
Merged

[MOB-12640] Unify Repro Steps List Item Title String #1002

merged 6 commits into from
Jul 25, 2023

Conversation

a7medev
Copy link
Contributor

@a7medev a7medev commented Jul 19, 2023 •
edited
Loading

Description of the change

  • Deprecate StringKey.reproStepsListItemTitle as it has inconsistent behavior between Android and iOS (it puts an extra # on iOS and doesn't put it on Android).
  • Introduce a consistent StringKey.reproStepsListItemNumberingTitle which adds the # on Android as well.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Issue links go here

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@a7medev a7medev self-assigned this Jul 19, 2023
@a7medev a7medev changed the base branch from master to dev July 19, 2023 10:56
@a7medev a7medev marked this pull request as ready for review July 19, 2023 11:05
@InstabugCI
Copy link
Collaborator

InstabugCI commented Jul 19, 2023 •
edited
Loading

Coverage Report

Label Coverage Status
JavaScript 96.5% ✅
Android 47.9% ✅
iOS 38.9% ✅

Generated by 🚫 dangerJS against 8603ed7

@a7medev a7medev requested a review from asamiz July 25, 2023 07:36
asamiz
asamiz approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@asamiz asamiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, good job @a7medev as usual

@a7medev a7medev merged commit 46a2f95 into dev Jul 25, 2023
@a7medev a7medev deleted the refactor/repro-steps-screen-string branch July 25, 2023 08:31
HeshamMegid pushed a commit that referenced this pull request Sep 17, 2023
@a7medev @HeshamMegid
[MOB-12640] Unify Repro Steps List Item Title String (#1002)
e08ad19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asamiz asamiz asamiz approved these changes

@abdelhamid-f-nasser abdelhamid-f-nasser Awaiting requested review from abdelhamid-f-nasser

Assignees

@a7medev a7medev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a7medev @InstabugCI @asamiz