Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MOB-12515] Support React Native 0.73 #1004

Merged
merged 4 commits into from
Jul 31, 2023
Merged

[MOB-12515] Support React Native 0.73 #1004

merged 4 commits into from
Jul 31, 2023

Conversation

asamiz
Copy link
Contributor

@asamiz asamiz commented Jul 25, 2023 •
edited by abdelhamid-f-nasser
Loading

Description of the change

Add SDK project namespace in build.gradle file to support the upcoming version of React Native(0.73) as it will use Android Gradle Plugin (AGP) version 8.x which will need the namespace to be specified. More here

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Issue links go here

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@InstabugCI
Copy link
Collaborator

InstabugCI commented Jul 25, 2023 •
edited
Loading

Coverage Report

Label Coverage Status
JavaScript 96.5% ✅
Android 47.9% ✅
iOS 38.9% ✅

Generated by 🚫 dangerJS against 857288a

abdelhamid-f-nasser
abdelhamid-f-nasser suggested changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@abdelhamid-f-nasser abdelhamid-f-nasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on introducing this magnificent changes to the Gradle build script! Just some minor suggestions regarding readability.

👌🏼 Keep up the great work! 🚀

android/build.gradle Outdated Show resolved Hide resolved
android/build.gradle Outdated Show resolved Hide resolved
android/build.gradle Outdated Show resolved Hide resolved
abdelhamid-f-nasser
abdelhamid-f-nasser approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@abdelhamid-f-nasser abdelhamid-f-nasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outstanding work ! 🎉 you've made the script even cleaner ! 👌🏼

@asamiz
Copy link
Contributor Author

asamiz commented Jul 31, 2023

@a7medev Need your review to close the PR.

a7medev
a7medev requested changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@a7medev a7medev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @asamiz! and thanks @abdelhamid-f-nasser for the detailed review 🙏🏼 I just have small one comment that needs to get resolved 🙏🏼

android/build.gradle Outdated Show resolved Hide resolved
@a7medev a7medev self-requested a review July 31, 2023 09:45
a7medev
a7medev approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@a7medev a7medev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @asamiz! 🚀❤️

@asamiz asamiz merged commit 17a34cd into dev Jul 31, 2023
@asamiz asamiz deleted the chore/add-RN0.73-support branch July 31, 2023 10:35
HeshamMegid pushed a commit that referenced this pull request Sep 17, 2023
@asamiz @HeshamMegid
[MOB-12515] Support React Native 0.73 (#1004)
9326e5a 
* chore(versionSupport): add namespace in build.gradle to support upcoming 0.73 version

* chore(versionSupport): fix PR comments

* chore(versionSupport): fix PR comments

* chore(versionSupport): modify the comment for clarification
@a7medev a7medev mentioned this pull request Sep 28, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a7medev a7medev a7medev approved these changes

@abdelhamid-f-nasser abdelhamid-f-nasser abdelhamid-f-nasser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asamiz @InstabugCI @abdelhamid-f-nasser @a7medev