Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support unhandled promise rejection crashes #1014

Merged
merged 8 commits into from
Sep 11, 2023
Merged

feat: support unhandled promise rejection crashes #1014

merged 8 commits into from
Sep 11, 2023

Conversation

a7medev
Copy link
Contributor

@a7medev a7medev commented Aug 30, 2023 •
edited
Loading

Description of the change

  • Add support for unhandled Promise rejection crashes in both the default promise polyfill and the one provided by Hermes.

Jira ID: MOB-12418

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Issue links go here

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@a7medev a7medev self-assigned this Aug 30, 2023
@InstabugCI
Copy link
Collaborator

InstabugCI commented Sep 3, 2023 •
edited
Loading

Coverage Report

Label Coverage Status
JavaScript 96.6% ✅
Android 49.6% ✅
iOS 38.9% ✅

Generated by 🚫 dangerJS against a661619

abdelhamid-f-nasser
abdelhamid-f-nasser approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@abdelhamid-f-nasser abdelhamid-f-nasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great effort and good job as always @a7medev 🚀

@a7medev a7medev merged commit 6195482 into dev Sep 11, 2023
@a7medev a7medev deleted the feat/support-unhandled-rejection branch September 11, 2023 09:01
HeshamMegid pushed a commit that referenced this pull request Sep 17, 2023
@a7medev @HeshamMegid
feat: support unhandled promise rejection crashes (#1014)
62be19a 
Jira ID: MOB-12418
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdelhamid-f-nasser abdelhamid-f-nasser abdelhamid-f-nasser approved these changes

@asamiz asamiz Awaiting requested review from asamiz

Assignees

@a7medev a7medev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a7medev @InstabugCI @abdelhamid-f-nasser