Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(android): bump sdk to 11.14.0 #1019

Merged
merged 7 commits into from
Sep 12, 2023
Merged

chore(android): bump sdk to 11.14.0 #1019

merged 7 commits into from
Sep 12, 2023

Conversation

abdelhamid-f-nasser
Copy link
Contributor

@abdelhamid-f-nasser abdelhamid-f-nasser commented Sep 6, 2023 •
edited
Loading

Description of the change

Bump Android SDK to 11.14.0

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

MOB-12990 -- subtask of --> MOB-12984

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@abdelhamid-f-nasser
chore(android): bump android sdk
0fc7fbb 
Upgrade android sdk to 11.14.0
@abdelhamid-f-nasser abdelhamid-f-nasser self-assigned this Sep 6, 2023
@abdelhamid-f-nasser abdelhamid-f-nasser marked this pull request as ready for review September 6, 2023 08:14
@InstabugCI
Copy link
Collaborator

InstabugCI commented Sep 6, 2023 •
edited
Loading

Coverage Report

Label Coverage Status
JavaScript 96.6% ✅
Android 49.6% ✅
iOS 38.9% ✅

Generated by 🚫 dangerJS against 762c921

a7medev
a7medev requested changes Sep 6, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@abdelhamid-f-nasser
docs: fix typo in #Changed section
0b92f37 
change Insabug to Instabug (missing a `t` )
asamiz
asamiz approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@asamiz asamiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @abdelhamid-f-nasser, this is an approval from my side

a7medev
a7medev requested changes Sep 10, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@abdelhamid-f-nasser
docs: re-order changelog.md sections
e322118 
Move changes section directly below the added section to match changelog standards
@abdelhamid-f-nasser
style: fix prettier format issues
d075afe 
remove empty line in CHANGELOG.md
@a7medev a7medev self-requested a review September 11, 2023 07:36
@abdelhamid-f-nasser abdelhamid-f-nasser merged commit a6c7b86 into dev Sep 12, 2023
@abdelhamid-f-nasser abdelhamid-f-nasser deleted the native/android/11.14.0 branch September 12, 2023 12:01
HeshamMegid pushed a commit that referenced this pull request Sep 17, 2023
@abdelhamid-f-nasser @HeshamMegid
chore(android): bump sdk to 11.14.0 (#1019)
922d25e 
Jira ID: MOB-12990
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asamiz asamiz asamiz approved these changes

@a7medev a7medev Awaiting requested review from a7medev

Assignees

@abdelhamid-f-nasser abdelhamid-f-nasser

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abdelhamid-f-nasser @InstabugCI @asamiz @a7medev