Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: deprecate old bug content string keys #1026

Merged
merged 2 commits into from
Sep 14, 2023
Merged

chore: deprecate old bug content string keys #1026

merged 2 commits into from
Sep 14, 2023

Conversation

a7medev
Copy link
Contributor

@a7medev a7medev commented Sep 14, 2023 •
edited
Loading

Description of the change

Deprecate the old StringKey.invalidCommentMessage and StringKey.invalidCommentTitle in favor of StringKey.insufficientContentMessage and StringKey.insufficientContentTitle.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Jira ID: MOB-13020

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@a7medev a7medev self-assigned this Sep 14, 2023
@InstabugCI
Copy link
Collaborator

InstabugCI commented Sep 14, 2023 •
edited
Loading

Coverage Report

Label Coverage Status
JavaScript 96.6% ✅
Android 50.0% ✅
iOS 39.2% ✅

Generated by 🚫 dangerJS against 5d77c09

@a7medev a7medev marked this pull request as ready for review September 14, 2023 12:46
abdelhamid-f-nasser
abdelhamid-f-nasser approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@abdelhamid-f-nasser abdelhamid-f-nasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely spot on! Great effort @a7medev 🎊. If only all PRs were as easy to review as this one! 😄👌🚀

@a7medev a7medev force-pushed the chore/deprecate-strings branch from 3bebbe8 to 5d77c09 Compare September 14, 2023 16:36
@a7medev a7medev merged commit ef62de0 into dev Sep 14, 2023
@a7medev a7medev deleted the chore/deprecate-strings branch September 14, 2023 16:58
HeshamMegid pushed a commit that referenced this pull request Sep 17, 2023
@a7medev @HeshamMegid
chore: deprecate old bug content string keys (#1026)
eb1ecff 
Jira ID: MOB-13020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdelhamid-f-nasser abdelhamid-f-nasser abdelhamid-f-nasser approved these changes

@asamiz asamiz Awaiting requested review from asamiz

Assignees

@a7medev a7medev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a7medev @InstabugCI @abdelhamid-f-nasser