Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove deprecated apis #1027

Merged
merged 13 commits into from
Sep 28, 2023
Merged

chore: remove deprecated apis #1027

merged 13 commits into from
Sep 28, 2023

Conversation

a7medev
Copy link
Contributor

@a7medev a7medev commented Sep 14, 2023 •
edited
Loading

Description of the change

Remove all deprecated APIs for v12.0.0 release.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Jira ID: MOB-12994

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@a7medev a7medev self-assigned this Sep 14, 2023
@a7medev a7medev changed the base branch from master to dev September 14, 2023 11:49
Base automatically changed from dev to master September 17, 2023 09:09
@asamiz asamiz force-pushed the chore/remove-deprecated-apis branch from 049c5e0 to b11af9b Compare September 21, 2023 12:43
@InstabugCI
Copy link
Collaborator

InstabugCI commented Sep 21, 2023 •
edited
Loading

Coverage Report

Label Coverage Status
JavaScript 96.0% ✅
Android 49.8% ✅
iOS 39.8% ✅

Generated by 🚫 dangerJS against 818a059

@abdelhamid-f-nasser abdelhamid-f-nasser mentioned this pull request Sep 26, 2023
Merged
7 tasks
@abdelhamid-f-nasser abdelhamid-f-nasser force-pushed the chore/remove-deprecated-apis branch 3 times, most recently from b04828f to d11a700 Compare September 27, 2023 15:36
@a7medev a7medev force-pushed the chore/remove-deprecated-apis branch from d11a700 to 662cfdc Compare September 28, 2023 08:01
@a7medev a7medev changed the base branch from master to dev September 28, 2023 08:24
a7medev and others added 12 commits September 28, 2023 11:47
@a7medev a7medev force-pushed the chore/remove-deprecated-apis branch from 392806c to 762dc33 Compare September 28, 2023 08:47
@a7medev a7medev marked this pull request as ready for review September 28, 2023 10:08
abdelhamid-f-nasser
abdelhamid-f-nasser approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@abdelhamid-f-nasser abdelhamid-f-nasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work as always 🚀 💪 ! I've rechecked the latest changes and it looks good to go.

@a7medev a7medev merged commit 3a29832 into dev Sep 28, 2023
@a7medev a7medev deleted the chore/remove-deprecated-apis branch September 28, 2023 11:12
HeshamMegid pushed a commit that referenced this pull request Oct 3, 2023
@a7medev @HeshamMegid
chore: remove deprecated apis (#1027)
d33164d 
Jira ID: MOB-12994
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdelhamid-f-nasser abdelhamid-f-nasser abdelhamid-f-nasser approved these changes

@asamiz asamiz Awaiting requested review from asamiz

Assignees

@a7medev a7medev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a7medev @InstabugCI @abdelhamid-f-nasser