Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump android sdk v12.1.0 #1032

Merged
merged 2 commits into from
Sep 28, 2023
Merged

chore: bump android sdk v12.1.0 #1032

merged 2 commits into from
Sep 28, 2023

Conversation

abdelhamid-f-nasser
Copy link
Contributor

@abdelhamid-f-nasser abdelhamid-f-nasser commented Sep 26, 2023 •
edited
Loading

Description of the change

Bump Android sdk to v.12.1.0

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Jira ID: MOB-13052

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

Depends on

@abdelhamid-f-nasser abdelhamid-f-nasser marked this pull request as draft September 26, 2023 07:57
@abdelhamid-f-nasser abdelhamid-f-nasser changed the base branch from master to chore/bump-ios-sdk-12.1.0 September 26, 2023 07:59
@abdelhamid-f-nasser abdelhamid-f-nasser marked this pull request as ready for review September 26, 2023 07:59
@abdelhamid-f-nasser abdelhamid-f-nasser force-pushed the chore/bump-android-sdk-12.1.0 branch from 19d20cc to 4df519a Compare September 27, 2023 15:50
@abdelhamid-f-nasser abdelhamid-f-nasser force-pushed the chore/bump-android-sdk-12.1.0 branch from 4df519a to f209cff Compare September 27, 2023 15:50
a7medev
a7medev approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@a7medev a7medev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfetto again! 👏🏼

@a7medev a7medev force-pushed the chore/bump-ios-sdk-12.1.0 branch 2 times, most recently from c19de60 to a1db7b3 Compare September 28, 2023 09:32
@a7medev a7medev force-pushed the chore/bump-android-sdk-12.1.0 branch 3 times, most recently from 7c0d8f7 to 5ea2d86 Compare September 28, 2023 09:45
@InstabugCI
Copy link
Collaborator

InstabugCI commented Sep 28, 2023 •
edited
Loading

Coverage Report

Label Coverage Status
JavaScript 96.0% ✅
Android 49.8% ✅
iOS 39.8% ✅

Generated by 🚫 dangerJS against 1d65d80

@abdelhamid-f-nasser abdelhamid-f-nasser force-pushed the chore/bump-android-sdk-12.1.0 branch from 5ea2d86 to 9aea8dd Compare September 28, 2023 11:11
@a7medev a7medev force-pushed the chore/bump-ios-sdk-12.1.0 branch from 5c08843 to 65ac379 Compare September 28, 2023 11:21
Base automatically changed from chore/bump-ios-sdk-12.1.0 to dev September 28, 2023 11:46
@a7medev a7medev force-pushed the chore/bump-android-sdk-12.1.0 branch from 9aea8dd to 1d65d80 Compare September 28, 2023 11:47
@a7medev a7medev merged commit d1317c1 into dev Sep 28, 2023
@a7medev a7medev deleted the chore/bump-android-sdk-12.1.0 branch September 28, 2023 12:12
HeshamMegid pushed a commit that referenced this pull request Oct 3, 2023
@abdelhamid-f-nasser @HeshamMegid
chore: bump android sdk v12.1.0 (#1032)
1fdbd40 
Jira ID: MOB-13052
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a7medev a7medev a7medev approved these changes

@asamiz asamiz Awaiting requested review from asamiz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abdelhamid-f-nasser @InstabugCI @a7medev