fix: fix and enhance AGP namespace support #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation calculates `isManifestContentUpdated` before applying any modifications to the file, so the manifest file was never updated. The fix was to calculate it right before updating the file.
abdelhamid-f-nasser
approved these changes
Oct 30, 2023
There was a problem hiding this comment.
The code looks excellent and is very self-explanatory 💪 !! Great effort supporting it @a7medev 👍
abdelhamid-f-nasser
pushed a commit
that referenced
this pull request
Nov 1, 2023
* fix: check for manifest updates before updating The current implementation calculates `isManifestContentUpdated` before applying any modifications to the file, so the manifest file was never updated. The fix was to calculate it right before updating the file. * refactor: enhance AGP namespace support * fix: resolve groovy compile issues * chore(android): keep package in initial manifest * chore: update changelog
HeshamMegid
pushed a commit
that referenced
this pull request
Nov 14, 2023
* fix: check for manifest updates before updating The current implementation calculates `isManifestContentUpdated` before applying any modifications to the file, so the manifest file was never updated. The fix was to calculate it right before updating the file. * refactor: enhance AGP namespace support * fix: resolve groovy compile issues * chore(android): keep package in initial manifest * chore: update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
The current implementation of Android Gradle Plugin >= 7.3.0 namespace support calculates
isManifestContentUpdatedbefore applying any modifications to the file, so the manifest file was never updated sinceisManifestContentUpdatedwill always befalse. The fix was to calculate it right before writing the updates to the file.I've changed the namespace support condition to check for AGP version >= 7.3 not only >= 7 since
namespacesupport was added in v7.3.0. I've also refactored the code into functions and renamed some variables for readability.I've also kept the
packageproperty in the initialAndroidManifest.xmlfile since having it removed by default causes the first app build to fail sometimes with apps not using AGP >= 7.3.0, while having it there in the initial run when it's not needed (when usingnamespace) won't cause trouble.I've tested these changes on React Native
0.66.0and0.73.0-rc.3and its working fine.Type of change
Related issues
Jira ID: INSD-10287
Checklists
Development
Code review