Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ios): sync JavaScript fatal crashes through promises #1054

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

a7medev
Copy link
Contributor

@a7medev a7medev commented Nov 9, 2023

Description of the change

Synchronize crash reporting fatal (unhandled) crashes with the iOS SDK through Promises instead of assuming the JavaScript-native call is sync (and it's not).

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Jira ID: MOB-13245

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@a7medev a7medev changed the base branch from master to dev November 9, 2023 13:13
@InstabugCI
Copy link
Collaborator

Your snapshot has been generated! 🚀

Installation

You can install the snapshot through NPM:

npm install https://github.com/Instabug/Instabug-React-Native\#snapshot/fix/sync-ios-fatal-crashes

or Yarn:

yarn add https://github.com/Instabug/Instabug-React-Native\#snapshot/fix/sync-ios-fatal-crashes

@InstabugCI
Copy link
Collaborator

InstabugCI commented Nov 9, 2023

Coverage Report

Label Coverage Status
JavaScript 95.8%
Android 50.3%
iOS 40.3%

Generated by 🚫 dangerJS against 8c76627

@InstabugCI
Copy link
Collaborator

Your snapshot has been generated! 🚀

Installation

You can install the snapshot through NPM:

npm install https://github.com/Instabug/Instabug-React-Native\#snapshot/fix/sync-ios-fatal-crashes

or Yarn:

yarn add https://github.com/Instabug/Instabug-React-Native\#snapshot/fix/sync-ios-fatal-crashes

@a7medev a7medev force-pushed the fix/sync-ios-fatal-crashes branch from b53e181 to 8c7ac41 Compare November 12, 2023 16:47
@a7medev a7medev changed the title chore: sync ios fatal crashes with promises chore(ios): sync JavaScript fatal crashes through promises Nov 12, 2023
@a7medev a7medev force-pushed the fix/sync-ios-fatal-crashes branch from 8c7ac41 to 3c91e2e Compare November 12, 2023 17:04
@a7medev a7medev self-assigned this Nov 12, 2023
Copy link
Contributor

@abdelhamid-f-nasser abdelhamid-f-nasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great effort and well done on resolving this issue 👌🚀

@a7medev a7medev merged commit a478a3f into dev Nov 13, 2023
@a7medev a7medev deleted the fix/sync-ios-fatal-crashes branch November 13, 2023 09:28
HeshamMegid pushed a commit that referenced this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants