fix(ios): enable screenshots for crashes & sessions #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdelhamid-f-nasser
force-pushed
the
chore/bump-ios-sdk-12.2.0
branch
from
8cedd3c to
87f56c4
Compare
abdelhamid-f-nasser
force-pushed
the
fix/enable-ios-screenshot-capture
branch
2 times, most recently
from
6ea93fc to
40da09d
Compare
a7medev
requested changes
Nov 13, 2023
a7medev
approved these changes
Nov 13, 2023
abdelhamid-f-nasser
changed the title
abdelhamid-f-nasser
force-pushed
the
chore/bump-ios-sdk-12.2.0
branch
from
31933b2 to
1d43ea8
Compare
abdelhamid-f-nasser
force-pushed
the
fix/enable-ios-screenshot-capture
branch
from
af16392 to
e5012ae
Compare
Remove redundant mapping in for iOS platform. Resolves previous workaround due to fixed iOS SDK issue. more about it [here](https://instabug.atlassian.net/browse/IBGCRASH-19924).
abdelhamid-f-nasser
force-pushed
the
fix/enable-ios-screenshot-capture
branch
from
e5012ae to
aa031ce
Compare
HeshamMegid
pushed a commit
that referenced
this pull request
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Remove unnecessary mapping that mapped ReproStepsMode.enabled to ReproStepsMode.enabledWithNoScreenshots for iOS platform. This workaround was added due to an issue with crashes repro steps with screenshots in the iOS SDK, and now it's no longer needed as the issue has been resolved. This re-enabled it for Crash Reporting and Session Replay.
Type of change
Related issues
Jira ID: IBGCRASH-20555
Checklists
Development
Code review