Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(android): sync JS fatal crashes via promises #1071

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

abdelhamid-f-nasser
Copy link
Contributor

@abdelhamid-f-nasser abdelhamid-f-nasser commented Nov 27, 2023

Description of the change

Wait for Android SDK to process the crash by waiting for sendJSCrashByReflection to finish before we crash the app.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Jira ID: MOB-13312

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

Testing scenarios

  • Test that an unhandled fatal crash is sent normally after relaunch

@abdelhamid-f-nasser abdelhamid-f-nasser force-pushed the fix/sync-android-fatal-crashes-via-promises branch from 124ea65 to bcddba5 Compare November 27, 2023 22:21
@InstabugCI
Copy link
Collaborator

InstabugCI commented Nov 27, 2023

Coverage Report

Label Coverage Status
JavaScript 96.2%
Android 50.2%
iOS 40.6%

Generated by 🚫 dangerJS against e1a50ac

@abdelhamid-f-nasser abdelhamid-f-nasser force-pushed the fix/sync-android-fatal-crashes-via-promises branch from bcddba5 to 7137ae3 Compare November 28, 2023 00:13
- Wait for `sendJSCrashByReflection` before resolving promise; crashing the app.
- Add entry for the fix
@abdelhamid-f-nasser abdelhamid-f-nasser force-pushed the fix/sync-android-fatal-crashes-via-promises branch from 7137ae3 to e1a50ac Compare November 28, 2023 00:48
@abdelhamid-f-nasser abdelhamid-f-nasser marked this pull request as ready for review November 28, 2023 00:56
Copy link
Contributor

@a7medev a7medev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect @abdelhamid-f-nasser, LGTM 👏🏼

@InstabugCI
Copy link
Collaborator

Your snapshot has been generated! 🚀

Installation

You can install the snapshot through NPM:

npm install https://github.com/Instabug/Instabug-React-Native\#snapshot/12.2.0-MOB-13312

or Yarn:

yarn add https://github.com/Instabug/Instabug-React-Native\#snapshot/12.2.0-MOB-13312

@abdelhamid-f-nasser abdelhamid-f-nasser merged commit 19ef21e into dev Nov 28, 2023
11 checks passed
@abdelhamid-f-nasser abdelhamid-f-nasser deleted the fix/sync-android-fatal-crashes-via-promises branch November 28, 2023 10:36
HeshamMegid pushed a commit that referenced this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants