Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ios): bump sdk to v12.4.0 #1074

Merged
merged 2 commits into from
Dec 6, 2023
Merged

chore(ios): bump sdk to v12.4.0 #1074

merged 2 commits into from
Dec 6, 2023

Conversation

abdelhamid-f-nasser
Copy link
Contributor

@abdelhamid-f-nasser abdelhamid-f-nasser commented Dec 4, 2023 •
edited
Loading

Description of the change

Bump iOS SDK to v12.4.0

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Jira ID: MOB-13349

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@abdelhamid-f-nasser abdelhamid-f-nasser changed the base branch from chore/bump-android-sdk-12.4.0 to chore/bump-android-sdk-12.4.1 December 5, 2023 18:53
@abdelhamid-f-nasser abdelhamid-f-nasser marked this pull request as ready for review December 5, 2023 18:54
@abdelhamid-f-nasser abdelhamid-f-nasser force-pushed the chore/bump-android-sdk-12.4.1 branch from b36f874 to c993fb8 Compare December 5, 2023 18:56
@abdelhamid-f-nasser abdelhamid-f-nasser force-pushed the chore/bump-ios-sdk-12.4.0 branch 2 times, most recently from ce0a17c to aac8c10 Compare December 5, 2023 19:26
@InstabugCI
Copy link
Collaborator

InstabugCI commented Dec 6, 2023 •
edited
Loading

Coverage Report

Label Coverage Status
JavaScript 96.2% ✅
Android 50.2% ✅
iOS 40.6% ✅

Generated by 🚫 dangerJS against 3e759b4

Base automatically changed from chore/bump-android-sdk-12.4.1 to dev December 6, 2023 20:14
a7medev
a7medev requested changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@a7medev a7medev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @abdelhamid-f-nasser ❤️ Please check the comment on the changelog.

CHANGELOG.md Outdated Show resolved Hide resolved
a7medev
a7medev approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@a7medev a7medev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙏🏼

@abdelhamid-f-nasser abdelhamid-f-nasser merged commit 2e00862 into dev Dec 6, 2023
9 of 10 checks passed
@abdelhamid-f-nasser abdelhamid-f-nasser deleted the chore/bump-ios-sdk-12.4.0 branch December 6, 2023 20:51
HeshamMegid pushed a commit that referenced this pull request Dec 7, 2023
@abdelhamid-f-nasser @HeshamMegid
chore(ios): bump sdk to v12.4.0 (#1074)
76536f9 
Jira ID: MOB-13349
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a7medev a7medev a7medev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abdelhamid-f-nasser @InstabugCI @a7medev