Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): remove current view update delay #1080

Merged
merged 4 commits into from
Jan 9, 2024
Merged

fix(android): remove current view update delay #1080

merged 4 commits into from
Jan 9, 2024

Conversation

abdelhamid-f-nasser
Copy link
Contributor

@abdelhamid-f-nasser abdelhamid-f-nasser commented Dec 12, 2023 •
edited
Loading

Description of the change

Utilize the new reportCurrentView API to report it immediately without delay. This eliminates the outdated 'Current View' values.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Jira ID: MOB-13396

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@abdelhamid-f-nasser abdelhamid-f-nasser changed the title chore: integrate reportCurrentViewChange fix: remove current view update delay Dec 12, 2023
@abdelhamid-f-nasser abdelhamid-f-nasser changed the title fix: remove current view update delay fix(android): remove current view update delay Dec 12, 2023
@abdelhamid-f-nasser abdelhamid-f-nasser requested review from a7medev and removed request for a7medev December 12, 2023 17:52
@abdelhamid-f-nasser abdelhamid-f-nasser added the pending-android Waiting for Android release label Dec 12, 2023
@abdelhamid-f-nasser abdelhamid-f-nasser force-pushed the fix/remove-current-view-update-delay branch 3 times, most recently from 178e54f to fea330c Compare December 13, 2023 18:01
@abdelhamid-f-nasser abdelhamid-f-nasser force-pushed the feat/support-code-push branch 3 times, most recently from e2c9e71 to c0c0a89 Compare January 7, 2024 13:41
@abdelhamid-f-nasser abdelhamid-f-nasser force-pushed the fix/remove-current-view-update-delay branch 2 times, most recently from 85623ea to a729255 Compare January 8, 2024 20:07
@abdelhamid-f-nasser abdelhamid-f-nasser force-pushed the fix/remove-current-view-update-delay branch from a729255 to 41e2743 Compare January 8, 2024 23:40
@abdelhamid-f-nasser
test: skip failing tests
1c23993 
Created Ticket to resolve these issues later.

The newly added tests fail other tests, try logging the currentScreen, _currentScreen and the checks will pass even though the conditional checks are not.
@abdelhamid-f-nasser abdelhamid-f-nasser force-pushed the fix/remove-current-view-update-delay branch from 41e2743 to 1c23993 Compare January 8, 2024 23:49
@InstabugCI
Copy link
Collaborator

Coverage Report

Label Coverage Status
JavaScript 96.2% ✅
Android 50.4% ✅
iOS 40.6% ✅

Generated by 🚫 dangerJS against 1c23993

@abdelhamid-f-nasser abdelhamid-f-nasser removed the pending-android Waiting for Android release label Jan 9, 2024
@abdelhamid-f-nasser abdelhamid-f-nasser marked this pull request as ready for review January 9, 2024 01:04
@abdelhamid-f-nasser abdelhamid-f-nasser changed the base branch from feat/support-code-push to dev January 9, 2024 01:05
@abdelhamid-f-nasser abdelhamid-f-nasser merged commit 547fa36 into dev Jan 9, 2024
9 of 10 checks passed
@abdelhamid-f-nasser abdelhamid-f-nasser deleted the fix/remove-current-view-update-delay branch January 9, 2024 01:06
HeshamMegid pushed a commit that referenced this pull request Jan 9, 2024
@abdelhamid-f-nasser @HeshamMegid
fix(android): remove current view update delay (#1080)
df66578 
Jira ID: MOB-13396
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abdelhamid-f-nasser @InstabugCI