Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add get session replay link API #1142

Merged
merged 7 commits into from
Feb 25, 2024
Merged

feat: add get session replay link API #1142

merged 7 commits into from
Feb 25, 2024

Conversation

ahmedAlaaInstabug
Copy link
Contributor

@ahmedAlaaInstabug ahmedAlaaInstabug commented Feb 20, 2024 •
edited
Loading

Description of the change

  1. Map OnSessionReplayLinkReady API that Retrieves the current session's replay link.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Jira ID = MOB-14010

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@ahmedAlaaInstabug ahmedAlaaInstabug self-assigned this Feb 20, 2024
@ahmedAlaaInstabug ahmedAlaaInstabug changed the title feat: Mapping-Session-Replay-links-api feat: Mapping SessionReplay link api Feb 20, 2024
@mnoseir
Copy link

mnoseir commented Feb 20, 2024 •
edited
Loading

Coverage Report

Label Coverage Status
JavaScript 96.3% ✅
Android 47.8% ✅
iOS 41.7% ✅

Generated by 🚫 dangerJS against e03a360

a7medev
a7medev requested changes Feb 25, 2024
View reviewed changes
Copy link
Contributor

@a7medev a7medev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, Alaa 👏🏼! Can you please check the comments I've added? 🙏🏼

android/src/main/java/com/instabug/reactlibrary/RNInstabugSessionReplayModule.java Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
android/src/test/java/com/instabug/reactlibrary/RNInstabugSessionReplayModuleTest.java Outdated Show resolved Hide resolved
examples/default/ios/InstabugTests/InstabugSessionReplayTests.m Outdated Show resolved Hide resolved
test/modules/SessionReplay.spec.ts Show resolved Hide resolved
@a7medev a7medev changed the title feat: Mapping SessionReplay link api feat: add get session replay link API Feb 25, 2024
abdelhamid-f-nasser
abdelhamid-f-nasser approved these changes Feb 25, 2024
View reviewed changes
Copy link
Contributor

@abdelhamid-f-nasser abdelhamid-f-nasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahmedAlaaInstabug Great effort and yet another great feature 👏 💪 !!!

@abdelhamid-f-nasser abdelhamid-f-nasser merged commit 7935891 into dev Feb 25, 2024
9 of 11 checks passed
@abdelhamid-f-nasser abdelhamid-f-nasser deleted the feat/Mapping-Session-Replay-links-api branch February 25, 2024 17:39
abdelhamid-f-nasser pushed a commit that referenced this pull request Feb 25, 2024
@ahmedAlaaInstabug @abdelhamid-f-nasser
feat: add get session replay link API (#1142)
2b04f68 
Jira ID: MOB-14010
abdelhamid-f-nasser pushed a commit that referenced this pull request Feb 25, 2024
@ahmedAlaaInstabug @abdelhamid-f-nasser
feat: add get session replay link API (#1142)
a627e5d 
Jira ID: MOB-14010
abdelhamid-f-nasser pushed a commit that referenced this pull request Feb 25, 2024
@ahmedAlaaInstabug @abdelhamid-f-nasser
feat: add get session replay link API (#1142)
d590d55 
Jira ID: MOB-14010
mzelzoghbi pushed a commit that referenced this pull request Feb 25, 2024
@ahmedAlaaInstabug @mzelzoghbi
feat: add get session replay link API (#1142)
91a97d6 
Jira ID: MOB-14010
abdelhamid-f-nasser pushed a commit that referenced this pull request Feb 28, 2024
@ahmedAlaaInstabug @abdelhamid-f-nasser
feat: add get session replay link API (#1142)
99752da 
Jira ID: MOB-14010
abdelhamid-f-nasser pushed a commit that referenced this pull request Feb 28, 2024
@ahmedAlaaInstabug @abdelhamid-f-nasser
feat: add get session replay link API (#1142)
a500f4e 
Jira ID: MOB-14010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdelhamid-f-nasser abdelhamid-f-nasser abdelhamid-f-nasser approved these changes

@a7medev a7medev Awaiting requested review from a7medev

Assignees

@ahmedAlaaInstabug ahmedAlaaInstabug

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ahmedAlaaInstabug @mnoseir @abdelhamid-f-nasser @a7medev