Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add custom app rating api #1186

Merged
merged 9 commits into from
Apr 19, 2024
Merged

feat: add custom app rating api #1186

merged 9 commits into from
Apr 19, 2024

Conversation

AndrewAminInstabug
Copy link
Contributor

@AndrewAminInstabug AndrewAminInstabug commented Apr 16, 2024 •
edited by a7medev
Loading

Description of the change

Map the below API to RN and Flutter

iOS: Instabug.willRedirectToAppStore()
Android: Instabug.willRedirectToAppStore();

This API is mainly used by the customer to mark that the user was redirected from the custom prompt to the App store or Play store so we can try to match the review to the relevant session replay

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Jira ID: MOB-14189

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@InstabugCI
Copy link
Collaborator

InstabugCI commented Apr 16, 2024 •
edited
Loading

Coverage Report

Label Coverage Status
JavaScript 96.3% ✅
Android 48.0% ✅
iOS 41.9% ✅

Generated by 🚫 dangerJS against 29d36eb

@a7medev a7medev changed the title Feat/map custom app rating api feat: map custom app rating api Apr 16, 2024
@a7medev a7medev changed the title feat: map custom app rating api feat: add custom app rating api Apr 16, 2024
@a7medev a7medev self-requested a review April 16, 2024 12:48
a7medev
a7medev requested changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@a7medev a7medev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @AndrewAminInstabug! 👏🏼 Please check the comments added. 🙏🏼

android/src/test/java/com/instabug/reactlibrary/RNInstabugReactnativeModuleTest.java Outdated Show resolved Hide resolved
android/src/test/java/com/instabug/reactlibrary/RNInstabugReactnativeModuleTest.java Outdated Show resolved Hide resolved
examples/default/ios/InstabugTests/InstabugSampleTests.m Outdated Show resolved Hide resolved
src/modules/Instabug.ts Outdated Show resolved Hide resolved
a7medev
a7medev reviewed Apr 17, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
AndrewAminInstabug and others added 2 commits April 17, 2024 14:52
@AndrewAminInstabug
update: test function name to follow the new naming conversions,
91a938d 
update: function (willRedirectToStore)implementation to be able to support older versions
@AndrewAminInstabug @a7medev
Update CHANGELOG.md
29d36eb 
Co-authored-by: Ahmed Mahmoud <[email protected]>
@ahmedAlaaInstabug ahmedAlaaInstabug merged commit fd90bd5 into dev Apr 19, 2024
10 of 13 checks passed
@ahmedAlaaInstabug ahmedAlaaInstabug deleted the feat/map_custom_app_rating_api branch April 19, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedAlaaInstabug ahmedAlaaInstabug ahmedAlaaInstabug left review comments

@a7medev a7medev a7medev requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AndrewAminInstabug @InstabugCI @a7medev @ahmedAlaaInstabug