feat: enhance non-fatals support

[ahmedAlaaInstabug]

Description of the change

1. add non fatal api

Type of change

• Bug fix (non-breaking change that fixes an issue)
• New feature (non-breaking change that adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

JIRA ID :

Checklists

Development

• Lint rules pass locally
• The code changed/added as part of this pull request has been covered with tests

Code review

• This pull request has a descriptive title and information useful to a reviewer
• Issue from task tracker has a link to this pull request

[InstabugCI]

Coverage Report

Label	Coverage	Status
JavaScript	99.2%	✅
Android	49.3%	✅
iOS	43.3%	✅

Generated by 🚫 dangerJS against 01a981c

[a7medev]

We should move these styles outside the component function to not get recreated with each render. We usually define it under the component function.

[a7medev]

This should be new Error I think.

Suggested change

	const error = Error(crashNameValue);
	const error = new Error(crashNameValue);

[a7medev]

We are already passing crashNameValue to new Error as a message (the first argument to the Error constructor is the message), so error.message will be empty only when crashNameValue is empty. I think we can just put the message we want to put in the constructor, no need for this check in my opinion.

[a7medev]

I think it'd be more readable to use Record<string, string> for userAttributes and simplify the conditions a bit.

I feel like the API signature is a bit verbose, so hopefully it gets better after the proposed change.

Suggested change

	const attrMap: { [k: string]: string } = {};
	attrMap[userAttributeKey] = userAttributeValue;
	CrashReporting.reportError(
	err,
	userAttributeValue.length === 0 || userAttributeKey.length === 0 ? null : attrMap,
	crashFingerprint.length === 0 ? null : crashFingerprint,
	crashLevelValue,
	).then(() => Alert.alert(`Crash report for ${crashNameValue} is Sent!`));
	const userAttributes: Record<string, string> = {};
	if (userAttributesKey && userAttributesValue) {
	userAttributes[userAttributesKey] = userAttributesValue;
	}
	CrashReporting.reportError(
	err,
	userAttributes,
	crashFingerprint || undefined,
	crashLevelValue,
	).then(() => Alert.alert(`Crash report for ${crashNameValue} is Sent!`));

[a7medev]

Map<string, string> is different from object literals (and Record<string, string> which is an object literal with a string key and string value), so the type of userAttributes here doesn't match what it is intended to be.

We can't pass JavaScript Maps to native methods, but we can pass object literals, so if we actually use Map in a real app it'd cause a crash.

[a7medev]

Good job @ahmedAlaaInstabug! 👏🏼 Just a couple of little comments and we should be good to go!

[a7medev]

Perfect! Let's gooo! 🚀🚀

The base branch was changed.