Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): resolve flavor path correctly in upload sourcemaps #1225

Merged
merged 6 commits into from
Sep 23, 2024
Merged

fix(android): resolve flavor path correctly in upload sourcemaps #1225

merged 6 commits into from
Sep 23, 2024

Conversation

ahmedAlaaInstabug
Copy link
Contributor

Description of the change

fix(android): reading sourcemap file

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

JIRA ID: INSD-11595

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@ahmedAlaaInstabug ahmedAlaaInstabug requested a review from a team May 31, 2024 14:12
@ahmedAlaaInstabug ahmedAlaaInstabug self-assigned this May 31, 2024
@InstabugCI
Copy link
Collaborator

InstabugCI commented May 31, 2024 •
edited
Loading

Coverage Report

Label Coverage Status
JavaScript 98.4% ✅
Android 50.2% ✅
iOS 47.9% ✅

Generated by 🚫 dangerJS against 098016f

Base automatically changed from dev to master June 6, 2024 16:31
a7medev
a7medev requested changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@a7medev a7medev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please add a changelog item? 🙏🏼

android/sourcemaps.gradle Outdated Show resolved Hide resolved
@a7medev a7medev changed the title fix(android): reading sourcemap file fix(android): resolve flavor path correctly in upload sourcemaps Sep 10, 2024
@sarahkhaledd sarahkhaledd added this to the 24Q3C2_W38 milestone Sep 22, 2024
@a7medev a7medev force-pushed the fix(android)/upload_sourcemap-gradle-task-flavor-issue branch from 92feab6 to 4ad2d1d Compare September 23, 2024 08:57
@a7medev a7medev changed the base branch from master to dev September 23, 2024 08:57
@a7medev a7medev merged commit 8869a82 into dev Sep 23, 2024
10 of 12 checks passed
@a7medev a7medev deleted the fix(android)/upload_sourcemap-gradle-task-flavor-issue branch September 23, 2024 15:00
YoussefFouadd pushed a commit that referenced this pull request Oct 16, 2024
@ahmedAlaaInstabug @a7medev @YoussefFouadd
fix(android): resolve flavor path correctly in upload sourcemaps (#1225)
ee2f721 
* fix source map

* fix: gradle sourcemap

* fix: added changelog item

* chore: update changelog

* refactor: move flavor path to variable

* refactor: make flavors backward-compatible

---------

Co-authored-by: Ahmed Mahmoud <[email protected]>
Signed-off-by: YoussefFouadd <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewAminInstabug AndrewAminInstabug AndrewAminInstabug approved these changes

@a7medev a7medev a7medev approved these changes

@kholood-ea kholood-ea Awaiting requested review from kholood-ea

@AyaMahmoud148 AyaMahmoud148 Awaiting requested review from AyaMahmoud148

Assignees

@ahmedAlaaInstabug ahmedAlaaInstabug

Labels
None yet
Projects
None yet
Milestone
24Q3C2_W38
Development

Successfully merging this pull request may close these issues.
5 participants
@ahmedAlaaInstabug @InstabugCI @a7medev @AndrewAminInstabug @sarahkhaledd