Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MOB-12027] Re-export NetworkData Type #932

Merged
merged 2 commits into from
Feb 28, 2023
Merged

[MOB-12027] Re-export NetworkData Type #932

merged 2 commits into from
Feb 28, 2023

Conversation

DavidMina96
Copy link
Contributor

Description of the change

Re-exports NetworkData type to be imported from instabug-reactnative.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Issue links go here

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@DavidMina96 DavidMina96 self-assigned this Feb 27, 2023
@DavidMina96 DavidMina96 linked an issue Feb 27, 2023 that may be closed by this pull request
[Bug] Project dist entry points missing/unaligned since 11.9.0 #930
Closed
a7medev
a7medev approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@a7medev a7medev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legit 👏

@DavidMina96 DavidMina96 merged commit 9a014d4 into dev Feb 28, 2023
@DavidMina96 DavidMina96 deleted the refactor/re-export-type branch February 28, 2023 12:39
HeshamMegid pushed a commit that referenced this pull request Mar 1, 2023
@DavidMina96 @HeshamMegid
[MOB-12027] Re-export NetworkData Type (#932)
881a2bb 
Re-export `NetworkData` type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a7medev a7medev a7medev approved these changes

@TheBuggedYRN TheBuggedYRN Awaiting requested review from TheBuggedYRN

Assignees

@DavidMina96 DavidMina96

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Project dist entry points missing/unaligned since 11.9.0
2 participants
@DavidMina96 @a7medev