Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MOB-11998] Use CLI in Sourcemaps Gradle Task #938

Merged
merged 6 commits into from
Mar 29, 2023
Merged

[MOB-11998] Use CLI in Sourcemaps Gradle Task #938

merged 6 commits into from
Mar 29, 2023

Conversation

TheBuggedYRN
Copy link
Contributor

@TheBuggedYRN TheBuggedYRN commented Mar 9, 2023 •
edited
Loading

Description of the change

Instead of depending on android/upload_sourcemaps.sh script to both generate and upload the sourcemap file, we now achieve the same result by:

  1. Using the sourcemaps file generated by React Native's bundleReleaseJsAndAssets.
  2. Passing the sourcemaps file path to the CLI to upload the file to our servers.

By dropping the shell script, the task can now work on Window machines.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Issue links go here

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@TheBuggedYRN TheBuggedYRN force-pushed the refactor/remove-android-shell-script branch from b80dd04 to 6ccf2b9 Compare March 9, 2023 11:36
@TheBuggedYRN TheBuggedYRN changed the title refactor/remove android shell script [MOB-11998] Use CLI in Sourcemaps Gradle Task Mar 9, 2023
@TheBuggedYRN TheBuggedYRN self-assigned this Mar 9, 2023
@TheBuggedYRN TheBuggedYRN force-pushed the refactor/remove-android-shell-script branch 2 times, most recently from a54e581 to 0675bb3 Compare March 9, 2023 13:36
@TheBuggedYRN TheBuggedYRN changed the base branch from dev to test/disable-android-upload-scripts March 9, 2023 13:38
@TheBuggedYRN TheBuggedYRN force-pushed the ci/disable-upload-scripts branch from a099e26 to 7f619f3 Compare March 9, 2023 15:09
Base automatically changed from ci/disable-upload-scripts to dev March 12, 2023 08:43
@TheBuggedYRN TheBuggedYRN force-pushed the refactor/remove-android-shell-script branch from 0675bb3 to fc8dda9 Compare March 12, 2023 12:50
@TheBuggedYRN TheBuggedYRN marked this pull request as draft March 20, 2023 11:46
@TheBuggedYRN TheBuggedYRN force-pushed the refactor/remove-android-shell-script branch from 0b74b55 to 80604c8 Compare March 27, 2023 13:28
@TheBuggedYRN TheBuggedYRN marked this pull request as ready for review March 28, 2023 11:07
@TheBuggedYRN TheBuggedYRN force-pushed the refactor/remove-android-shell-script branch from ce2dd72 to f516327 Compare March 28, 2023 12:38
@TheBuggedYRN TheBuggedYRN force-pushed the refactor/remove-android-shell-script branch from f516327 to 26c5017 Compare March 28, 2023 12:41
@TheBuggedYRN TheBuggedYRN merged commit 7af43fd into dev Mar 29, 2023
@TheBuggedYRN TheBuggedYRN deleted the refactor/remove-android-shell-script branch March 29, 2023 09:28
HeshamMegid pushed a commit that referenced this pull request Apr 20, 2023
@TheBuggedYRN @HeshamMegid
[MOB-11998] Use CLI in Sourcemaps Gradle Task (#938)
3a3d932
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a7medev a7medev Awaiting requested review from a7medev

@DavidMina96 DavidMina96 Awaiting requested review from DavidMina96

Assignees

@TheBuggedYRN TheBuggedYRN

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@TheBuggedYRN