Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MOB-10486] Change APIs with Callbacks to Promises #948

Merged
merged 14 commits into from
Apr 11, 2023
Merged

[MOB-10486] Change APIs with Callbacks to Promises #948

merged 14 commits into from
Apr 11, 2023

Conversation

a7medev
Copy link
Contributor

@a7medev a7medev commented Mar 15, 2023

Description of the change

Description goes here

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Issue links go here

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@a7medev a7medev self-assigned this Mar 15, 2023
@a7medev a7medev marked this pull request as ready for review March 16, 2023 14:55
@a7medev a7medev force-pushed the refactor/callbacks-to-promises branch 5 times, most recently from 0013c9e to 4f2c65d Compare March 21, 2023 09:52
TheBuggedYRN
TheBuggedYRN reviewed Mar 22, 2023
View reviewed changes
src/utils/InstabugUtils.ts Show resolved Hide resolved
test/mocks/mockReplies.ts Outdated Show resolved Hide resolved
@a7medev a7medev force-pushed the refactor/callbacks-to-promises branch 2 times, most recently from 8eb0272 to b64cf7b Compare March 29, 2023 09:36
@a7medev a7medev requested a review from TheBuggedYRN March 29, 2023 09:37
@stale
Copy link

stale bot commented Apr 5, 2023

This issue has been automatically marked as pending feedback because we need additional information to be able to investigate it further. It will be closed in 7 days if it remains inactive. Thank you for your contributions.

@DavidMina96 DavidMina96 added the WIP Work In Progress label Apr 7, 2023
@stale stale bot removed the Pending Feedback label Apr 7, 2023
@a7medev a7medev force-pushed the refactor/callbacks-to-promises branch from b64cf7b to 1c4f7ee Compare April 10, 2023 13:01
DavidMina96
DavidMina96 reviewed Apr 11, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@a7medev a7medev requested a review from DavidMina96 April 11, 2023 09:43
@a7medev a7medev merged commit dadd2aa into dev Apr 11, 2023
@a7medev a7medev deleted the refactor/callbacks-to-promises branch April 11, 2023 12:02
@a7medev a7medev removed the WIP Work In Progress label Apr 11, 2023
HeshamMegid pushed a commit that referenced this pull request Apr 20, 2023
@a7medev @HeshamMegid
[MOB-10486] Change APIs with Callbacks to Promises (#948)
98d5236
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidMina96 DavidMina96 DavidMina96 approved these changes

@TheBuggedYRN TheBuggedYRN Awaiting requested review from TheBuggedYRN

Assignees

@a7medev a7medev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a7medev @DavidMina96 @TheBuggedYRN