Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MOB-12305] Fix Sourcemaps Upload Script with Android Product Flavors #975

Merged
merged 3 commits into from
May 2, 2023
Merged

[MOB-12305] Fix Sourcemaps Upload Script with Android Product Flavors #975

merged 3 commits into from
May 2, 2023

Conversation

a7medev
Copy link
Contributor

@a7medev a7medev commented May 1, 2023 •
edited
Loading

Description of the change

Problem

The new Android sourcemaps upload script can’t detect the [create]Bundle[Flavor]ReleaseJsAndAssets when the user is using the Android product flavors feature.

Solution

Check for a suffix of ReleaseJsAndAssets instead of looking for a suffix of bundleReleaseJsAndAssets (ignoring the casing.)

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fixes #974

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@a7medev a7medev self-assigned this May 1, 2023
@a7medev a7medev changed the base branch from master to dev May 1, 2023 12:52
@a7medev a7medev marked this pull request as ready for review May 1, 2023 12:52
@a7medev a7medev requested a review from DavidMina96 May 1, 2023 12:52
@InstabugCI
Copy link
Collaborator

InstabugCI commented May 1, 2023 •
edited
Loading

Coverage Report

Label Coverage Status
JavaScript 96.8% ✅
Android 47.8% ✅
iOS 39.0% ✅

Generated by 🚫 dangerJS against deef299

@a7medev a7medev mentioned this pull request May 2, 2023
Closed
@a7medev a7medev merged commit 2beb1f7 into dev May 2, 2023
@a7medev a7medev deleted the fix/sourcemaps-upload-flavors-support branch May 2, 2023 11:46
@a7medev a7medev mentioned this pull request May 9, 2023
Merged
7 tasks
@a7medev a7medev restored the fix/sourcemaps-upload-flavors-support branch May 9, 2023 13:56
HeshamMegid pushed a commit that referenced this pull request May 30, 2023
@a7medev @HeshamMegid
[MOB-12305] Fix Sourcemaps Upload Script with Android Product Flavors (…
b6daff5 
…#975)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidMina96 DavidMina96 DavidMina96 approved these changes

Assignees

@a7medev a7medev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Android build fail when if productFlavors configurated
3 participants
@a7medev @InstabugCI @DavidMina96