Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INSD-9579] Fix Unhandled JavaScript Crashes on Android #980

Merged
merged 2 commits into from
May 22, 2023
Merged

[INSD-9579] Fix Unhandled JavaScript Crashes on Android #980

merged 2 commits into from
May 22, 2023

Conversation

a7medev
Copy link
Contributor

@a7medev a7medev commented May 19, 2023

Description of the change

Fix an issue with unhandled JavaScript crashes not being reported correctly on Android when we removed the setTimeout around the original global error handler call.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Issue links go here

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@a7medev a7medev requested a review from DavidMina96 May 19, 2023 12:04
@a7medev a7medev self-assigned this May 19, 2023
@a7medev a7medev changed the base branch from master to dev May 19, 2023 12:05
@a7medev a7medev changed the title [INSD-9548] Fix Unhandled JavaScript Crashes on Android [INSD-9579] Fix Unhandled JavaScript Crashes on Android May 19, 2023
@InstabugCI
Copy link
Collaborator

Coverage Report

Label Coverage Status
JavaScript 96.5% ✅
Android 47.8% ✅
iOS 39.0% ✅

Generated by 🚫 dangerJS against 7825321

@a7medev a7medev merged commit 0a6485c into dev May 22, 2023
@a7medev a7medev deleted the fix/unhandled-js-crashes-android branch May 22, 2023 09:46
HeshamMegid pushed a commit that referenced this pull request May 30, 2023
@a7medev @HeshamMegid
[INSD-9579] Fix Unhandled JavaScript Crashes on Android (#980)
a8f77b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidMina96 DavidMina96 DavidMina96 approved these changes

Assignees

@a7medev a7medev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a7medev @InstabugCI @DavidMina96