Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MOB-12414] Disable Android Sourcemaps Upload with Env Var #983

Merged
merged 6 commits into from
May 25, 2023
Merged

[MOB-12414] Disable Android Sourcemaps Upload with Env Var #983

merged 6 commits into from
May 25, 2023

Conversation

DavidMina96
Copy link
Contributor

Description of the change

  • Deprecate instabugUploadEnable gradle property to disable Android Sourcemaps auto upload in favor of INSTABUG_SOURCEMAPS_UPLOAD_DISABLE env variable.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Issue links go here

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@InstabugCI
Copy link
Collaborator

InstabugCI commented May 24, 2023 •
edited
Loading

Coverage Report

Label Coverage Status
JavaScript 96.5% ✅
Android 47.8% ✅
iOS 39.0% ✅

Generated by 🚫 dangerJS against 111ff52

@DavidMina96 DavidMina96 self-assigned this May 24, 2023
@DavidMina96 DavidMina96 requested a review from a7medev May 24, 2023 12:45
@DavidMina96 DavidMina96 force-pushed the feature/disable-android-sourcemaps-using-env branch from 95eea67 to f352fc8 Compare May 24, 2023 13:07
a7medev
a7medev requested changes May 25, 2023
View reviewed changes
android/sourcemaps.gradle Outdated Show resolved Hide resolved
@DavidMina96 DavidMina96 requested a review from a7medev May 25, 2023 12:08
a7medev
a7medev requested changes May 25, 2023
View reviewed changes
android/sourcemaps.gradle Outdated Show resolved Hide resolved
android/sourcemaps.gradle Outdated Show resolved Hide resolved
@DavidMina96 DavidMina96 force-pushed the feature/disable-android-sourcemaps-using-env branch from b217760 to 111ff52 Compare May 25, 2023 12:31
@DavidMina96 DavidMina96 requested review from a7medev May 25, 2023 12:32
@DavidMina96 DavidMina96 merged commit c93434c into dev May 25, 2023
@DavidMina96 DavidMina96 deleted the feature/disable-android-sourcemaps-using-env branch May 25, 2023 13:01
HeshamMegid pushed a commit that referenced this pull request May 30, 2023
@DavidMina96 @HeshamMegid
[MOB-12414] Disable Android Sourcemaps Upload with Env Var (#983)
c7f00e5 
Deprecate instabugUploadEnable gradle property to disable Android Sourcemaps auto upload in favor of INSTABUG_SOURCEMAPS_UPLOAD_DISABLE env variable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a7medev a7medev Awaiting requested review from a7medev

Assignees

@DavidMina96 DavidMina96

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DavidMina96 @InstabugCI @a7medev