Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MOB-12473] Skip Recreating Sourcemaps Gradle Task If It Exists #991

Merged
merged 3 commits into from
Jun 21, 2023
Merged

[MOB-12473] Skip Recreating Sourcemaps Gradle Task If It Exists #991

merged 3 commits into from
Jun 21, 2023

Conversation

a7medev
Copy link
Contributor

@a7medev a7medev commented Jun 12, 2023

Description of the change

Fix an issue with the Android sourcemaps upload Gradle task getting recreated when both bundleReleaseJsAndAssets and createBundleReleaseJsAndAssets tasks exist in the same Android project by defaulting to the existent task when it exists.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fixes #989

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@a7medev a7medev self-assigned this Jun 12, 2023
@a7medev a7medev requested a review from asamiz June 12, 2023 12:07
@InstabugCI
Copy link
Collaborator

InstabugCI commented Jun 12, 2023 •
edited
Loading

Coverage Report

Label Coverage Status
JavaScript 96.5% ✅
Android 47.8% ✅
iOS 39.0% ✅

Generated by 🚫 dangerJS against c1154ed

asamiz
asamiz approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@asamiz asamiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @a7medev, this is an approval from my side on those changes!

@a7medev a7medev mentioned this pull request Jun 15, 2023
Closed
@a7medev a7medev merged commit e8e0f72 into dev Jun 21, 2023
@a7medev a7medev deleted the fix/upload-sourcemaps-conflict branch June 21, 2023 15:19
HeshamMegid pushed a commit that referenced this pull request Jul 10, 2023
@a7medev @HeshamMegid
[MOB-12473] Skip Recreating Sourcemaps Gradle Task If It Exists (#991)
79e4d9e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asamiz asamiz asamiz approved these changes

Assignees

@a7medev a7medev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a7medev @InstabugCI @asamiz