Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MOB-12511] Replace JaCoCo’s enabled with required #995

Merged
merged 3 commits into from
Jul 5, 2023
Merged

[MOB-12511] Replace JaCoCo’s enabled with required #995

merged 3 commits into from
Jul 5, 2023

Conversation

asamiz
Copy link
Contributor

@asamiz asamiz commented Jul 3, 2023 •
edited by a7medev
Loading

Description of the change

Replace the enabled method with required property in JaCoCo gradle plugin as it breaks the gradle scripts running on version 0.72.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fixes #994

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@asamiz asamiz requested a review from a7medev July 3, 2023 08:59
@InstabugCI
Copy link
Collaborator

InstabugCI commented Jul 3, 2023 •
edited
Loading

Coverage Report

Label Coverage Status
JavaScript 96.5% ✅
Android 47.8% ✅
iOS 39.0% ✅

Generated by 🚫 dangerJS against d2397dc

@asamiz asamiz changed the title [MOB-12511] Replace Enabled Method with Required Prop in JaCoCo Gradle Plugin [MOB-12511] Replace JaCoCo’s enabled with required Jul 3, 2023
a7medev
a7medev requested changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@a7medev a7medev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asamiz Great job fixing and testing this! 👏🏼❤️
Just a tiny change and we are good to go 🚀

android/jacoco.gradle Outdated Show resolved Hide resolved
@a7medev a7medev self-requested a review July 3, 2023 12:12
@a7medev a7medev self-requested a review July 3, 2023 12:13
a7medev
a7medev requested changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@a7medev a7medev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asamiz One last change, please add a changelog item for this change 🙏🏼

@a7medev a7medev self-requested a review July 4, 2023 08:16
@asamiz asamiz merged commit 60008b8 into dev Jul 5, 2023
@asamiz asamiz deleted the fix/jacoco-gradle-plugin-props branch July 5, 2023 09:21
HeshamMegid pushed a commit that referenced this pull request Jul 10, 2023
@asamiz @HeshamMegid
[MOB-12511] Replace JaCoCo’s enabled with required (#995)
dbb8bf5 
* fix(jacoco-reports): replace enabled prop with required for html and xml reports

* fix(jacoco-reports): fix PR comments

* chore(jacoco-reporting): add changes to CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a7medev a7medev a7medev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asamiz @InstabugCI @a7medev