Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed error in cast dtype for full() function. #1002

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Fixed error in cast dtype for full() function. #1002

merged 1 commit into from
Nov 30, 2022

Conversation

npolina4
Copy link
Collaborator

Fixed error in pybind11 for casting some types in dpctl.tensot.full() function.
Added tests.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?

@github-actions
Copy link

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1002/index.html

@coveralls
Copy link
Collaborator

Coverage Status

Coverage increased (+0.02%) to 82.028% when pulling e7e8508 on fixed_dtype_full into 1b1eb15 on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.0=py310h8c27c75_16 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

oleksandr-pavlyk
oleksandr-pavlyk approved these changes Nov 30, 2022
View reviewed changes
Copy link
Collaborator

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @npolina4 !

@oleksandr-pavlyk oleksandr-pavlyk merged commit d8704f0 into master Nov 30, 2022
@oleksandr-pavlyk oleksandr-pavlyk deleted the fixed_dtype_full branch November 30, 2022 16:35
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.0=py310h8c27c75_18 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleksandr-pavlyk oleksandr-pavlyk oleksandr-pavlyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@npolina4 @coveralls @oleksandr-pavlyk