Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sycl queue argument validation #1052

Merged
merged 3 commits into from
Feb 1, 2023
Merged

Fix sycl queue argument validation #1052

merged 3 commits into from
Feb 1, 2023

Conversation

oleksandr-pavlyk
Copy link
Collaborator

This fixes lack of validation in dpctl.SyclQueue(device="gpu") call to constructor.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@github-actions
Copy link

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1052/index.html

@coveralls
Copy link
Collaborator

coveralls commented Jan 31, 2023 •
edited
Loading

Coverage Status

Coverage: 82.088% (-0.01%) from 82.102% when pulling 8dd757b on fix-sycl-queue-argument-validation into db8fe2f on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_53 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_54 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

@oleksandr-pavlyk oleksandr-pavlyk merged commit 1c9dc56 into master Feb 1, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the fix-sycl-queue-argument-validation branch February 1, 2023 19:41
@github-actions
Copy link

github-actions bot commented Feb 1, 2023

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

github-actions bot commented Feb 1, 2023

Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_54 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

@antonwolfy antonwolfy mentioned this pull request Feb 9, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oleksandr-pavlyk @coveralls