Changed simplify_iteration_two_strides, simplify_iteration_three_strides #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The target ordering used to be based on absolute values of the first vector of strides, now it uses lexicographic ordering of tuples of absolute values of all strides involved. This enables iteration space reduction for examples where all strides in the first vector are all zero, like in the example arising from ``` dpctl.tensor.full((2,3,4,), dpctl.tensor.asarray(1)) ``` The following two invocations show that iteration space used is 1d: ``` onetrace -d -v --demangle python -c "import dpctl.tensor as dpt; x = dpt.ones((30, 40, 50), dtype='i4'); y = dpt.empty_like(x, dtype='f4'); print((x.flags, y.flags)); y[:] = x" onetrace -d -v --demangle python -c "import dpctl.tensor._tensor_impl as ti, dpctl.tensor as dpt; dpt.full((2,3,4), dpt.asarray(1, dtype='f4'))" ```
oleksandr-pavlyk
force-pushed
the
enhance-iter-space-simplification
branch
from
1fbe04e to
078493e
Compare
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/1054/index.html |
|
Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_56 ran successfully. |
|
Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_52 ran successfully. |
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_62 ran successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The target ordering used to be based on absolute values of the first vector of strides, now it uses lexicographic ordering of tuples of absolute values of all strides involved.
This enables iteration space reduction for examples where all strides in the first vector are all zero, like in the example arising from
The following two invocations show that iteration space used is 1d: