Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing usm_type to tril() and triu() functions. #1062

Merged
merged 2 commits into from
Feb 6, 2023

Conversation

npolina4
Copy link
Collaborator

@npolina4 npolina4 commented Feb 6, 2023

Allocation for the result array did not honor usm_type of the argument for dpctl.tensor.tril, dpctl.tensor.triu functions.

This PR fixes that and adds tests.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@coveralls
Copy link
Collaborator

Coverage Status

Coverage: ?%. Remained the same when pulling e0b79ff on fix_tril_triu_usm_type into 7c15231 on master.

@coveralls
Copy link
Collaborator

coveralls commented Feb 6, 2023

Coverage Status

Coverage: 82.208%. Remained the same when pulling ec8509f on fix_tril_triu_usm_type into 7c15231 on master.

@github-actions
Copy link

github-actions bot commented Feb 6, 2023

Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_79 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

@github-actions
Copy link

github-actions bot commented Feb 6, 2023

Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_80 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

@github-actions
Copy link

github-actions bot commented Feb 6, 2023

Copy link
Collaborator

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR descriptions, and tests are useful.

PR description is useful for release note writing, and tests are useful for regression testing.

@oleksandr-pavlyk oleksandr-pavlyk merged commit 4ed654f into master Feb 6, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the fix_tril_triu_usm_type branch February 6, 2023 13:48
@github-actions
Copy link

github-actions bot commented Feb 6, 2023

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

github-actions bot commented Feb 6, 2023

Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_80 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants