-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added missing usm_type to tril() and triu() functions. #1062
Conversation
Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_79 ran successfully. |
Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_80 ran successfully. |
View rendered docs @ https://intelpython.github.io/dpctl/pulls/1062/index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR descriptions, and tests are useful.
PR description is useful for release note writing, and tests are useful for regression testing.
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_80 ran successfully. |
Allocation for the result array did not honor
usm_type
of the argument fordpctl.tensor.tril
,dpctl.tensor.triu
functions.This PR fixes that and adds tests.